Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support 'SHOW CONFIG' syntax to show configs of PD and TiKV instances (#16230) #16475

Merged
merged 3 commits into from
Apr 23, 2020
Merged

executor: support 'SHOW CONFIG' syntax to show configs of PD and TiKV instances (#16230) #16475

merged 3 commits into from
Apr 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 16, 2020

cherry-pick #16230 to release-4.0

What problem does this PR solve?

Issue Number: close #16229

Problem Summary: support SHOW CONFIG syntax to show configs of PD and TiKV instances

What is changed and how it works?

When processing SHOW CONFIG, the ShowExec fetches all configs from PD and show them to the user.

After this PR:

mysql> show config where type='pd' and name like '%log.file%';
+------+----------------+----------------------+-------+
| Type | Instance       | Name                 | Value |
+------+----------------+----------------------+-------+
| pd   | 127.0.0.1:2379 | log.file.filename    |       |
| pd   | 127.0.0.1:2379 | log.file.max-backups | 0     |
| pd   | 127.0.0.1:2379 | log.file.max-days    | 0     |
| pd   | 127.0.0.1:2379 | log.file.max-size    | 0     |
+------+----------------+----------------------+-------+

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test

@sre-bot sre-bot requested review from a team as code owners April 16, 2020 09:52
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 16, 2020
Merged
@ghost ghost requested a review from lzmhhh123 April 16, 2020 09:52
@qw4990
Copy link
Contributor

qw4990 commented Apr 16, 2020

/run-all-tests

zz-jason
zz-jason reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2020
wshwsh12
wshwsh12 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-all-tests

@qw4990 qw4990 mentioned this pull request Apr 23, 2020
Merged
@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-integration-copr-test

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-integration-copr-test

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-integration-copr-test

@zz-jason zz-jason merged commit 24e6f76 into pingcap:release-4.0 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@NingLin-P NingLin-P Awaiting requested review from NingLin-P

@rleungx rleungx Awaiting requested review from rleungx

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@qw4990 qw4990

Labels
component/config sig/execution SIG execution status/LGT1 Indicates that a PR has LGTM 1. type/new-feature type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @qw4990 @zz-jason @wshwsh12