-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, config: update the way to show array config items when using show config
(#16712)
#16761
Merged
zz-jason
merged 4 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-d25d0a5d6f78
Apr 23, 2020
Merged
executor, config: update the way to show array config items when using show config
(#16712)
#16761
zz-jason
merged 4 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-d25d0a5d6f78
Apr 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
Wait for #16082. |
wait for #16475. |
/run-all-tests |
wshwsh12
reviewed
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-sqllogic-test-2 |
zz-jason
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
status/all-tests-passed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/config
sig/execution
SIG execution
status/LGT2
Indicates that a PR has LGTM 2.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16712 to release-4.0
What problem does this PR solve?
Issue Number: close #16704
After #16229, we can use
show config
to get configs ofPD
andTiKV
.If some config item is an array, it will be flattened and each element of it is shown in an individual row, which is not user-friendly.
For example, the config item
engines = ["tikv", "tiflash", "tidb"]
will be shown as:After this PR, it will be shown as:
This new format is easier to understand and safer to update.
Check List
Tests