Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, config: update the way to show array config items when using show config (#16712) #16761

Merged
merged 4 commits into from
Apr 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 23, 2020

cherry-pick #16712 to release-4.0


What problem does this PR solve?

Issue Number: close #16704

After #16229, we can use show config to get configs of PD and TiKV.
If some config item is an array, it will be flattened and each element of it is shown in an individual row, which is not user-friendly.
For example, the config item engines = ["tikv", "tiflash", "tidb"] will be shown as:

+------+--------------+--------------------------+---------+
| Type | Instance     | Name                     | Value   |
+------+--------------+--------------------------+---------+
| tidb | 0.0.0.0:4000 | isolation-read.engines.0 | tikv    |
| tidb | 0.0.0.0:4000 | isolation-read.engines.1 | tiflash |
| tidb | 0.0.0.0:4000 | isolation-read.engines.2 | tidb    |
+------+--------------+--------------------------+---------+

After this PR, it will be shown as:

+------+--------------+--------------------------+------------------------------+
| Type | Instance     | Name                     | Value                        |
+------+--------------+--------------------------+------------------------------+
| tidb | 0.0.0.0:4000 | isolation-read.engines   | ["tikv", "tiflash", "tidb"]  |
+------+--------------+--------------------------+------------------------------+

This new format is easier to understand and safer to update.

Check List

Tests

  • Unit test

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested a review from a team as a code owner April 23, 2020 08:27
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

Wait for #16082.

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

wait for #16475.

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-all-tests

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Apr 23, 2020

/run-sqllogic-test-2

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit ae09d8c into pingcap:release-4.0 Apr 23, 2020
@zz-jason zz-jason added status/all-tests-passed status/LGT2 Indicates that a PR has LGTM 2. labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants