Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics/grafana: add more Golang MemStats metrics #16902

Merged
merged 4 commits into from
Apr 29, 2020
Merged

metrics/grafana: add more Golang MemStats metrics #16902

merged 4 commits into from
Apr 29, 2020

Conversation

SunRunAway
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #16900

Problem Summary:
Currently, it only has go_memstats_heap_alloc_bytes metric in grafana. We need more metrics showing runtime.MemStats.

What is changed and how it works?

Proposal: xxx

What's Changed:

Add these metrics:

  1. go_memstats_heap_sys_bytes ("hide": true)
  2. go_memstats_heap_inuse_bytes ("hide": false)
  3. go_memstats_heap_alloc_bytes ("hide": true)
  4. go_memstats_heap_idle_bytes ("hide": true)
  5. go_memstats_heap_released_bytes ("hide": true)

How it Works:

Related changes

  • Need to cherry-pick to the release branch
    • 4.0

Check List

Tests

  • No code

Side effects

  • None

Release note

  • None

@SunRunAway SunRunAway requested a review from jackysp April 28, 2020 06:36
zz-jason
zz-jason reviewed Apr 28, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2020
@jackysp
Copy link
Member

jackysp commented Apr 28, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2020

Visit the grafana server at: http://172.16.5.5:31533, it will last for 5 hours

@tiancaiamao
Copy link
Contributor

LGTM @jackysp

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2020
jackysp
jackysp approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 29, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #16902 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16902   +/-   ##
===========================================
  Coverage   80.3975%   80.3975%           
===========================================
  Files           508        508           
  Lines        137498     137498           
===========================================
  Hits         110545     110545           
  Misses        18291      18291           
  Partials       8662       8662

@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

@SunRunAway merge failed.

@zz-jason zz-jason merged commit cd362ca into pingcap:master Apr 29, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 29, 2020
@SunRunAway @sre-bot
metrics/grafana: add more Golang MemStats metrics (pingcap#16902)
d4388da
@sre-bot sre-bot mentioned this pull request Apr 29, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 29, 2020

cherry pick to release-4.0 in PR #16928

@SunRunAway SunRunAway deleted the grafana branch April 29, 2020 06:27
sre-bot added a commit that referenced this pull request Apr 30, 2020
@sre-bot
metrics/grafana: add more Golang MemStats metrics (#16902) (#16928)
6d4f006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grafana: add more Golang MemStats metrics
5 participants
@SunRunAway @jackysp @sre-bot @tiancaiamao @zz-jason