Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics/grafana: add more Golang MemStats metrics (#16902) #16928

Merged
merged 3 commits into from
Apr 30, 2020
Merged

metrics/grafana: add more Golang MemStats metrics (#16902) #16928

merged 3 commits into from
Apr 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 29, 2020

cherry-pick #16902 to release-4.0

What problem does this PR solve?

Issue Number: close #16900

Problem Summary:
Currently, it only has go_memstats_heap_alloc_bytes metric in grafana. We need more metrics showing runtime.MemStats.

What is changed and how it works?

Proposal: xxx

What's Changed:

Add these metrics:

  1. go_memstats_heap_sys_bytes ("hide": true)
  2. go_memstats_heap_inuse_bytes ("hide": false)
  3. go_memstats_heap_alloc_bytes ("hide": true)
  4. go_memstats_heap_idle_bytes ("hide": true)
  5. go_memstats_heap_released_bytes ("hide": true)

How it Works:

Related changes

  • Need to cherry-pick to the release branch
    • 4.0

Check List

Tests

  • No code

Side effects

  • None

Release note

  • None

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 29, 2020
Merged
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone Apr 29, 2020
zz-jason
zz-jason reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazycs520
crazycs520 approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 29, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

@sre-bot merge failed.

@jackysp
Copy link
Member

jackysp commented Apr 30, 2020

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6d4f006 into pingcap:release-4.0 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@jackysp jackysp Awaiting requested review from jackysp

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees

@SunRunAway SunRunAway

Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @jackysp @zz-jason @crazycs520 @SunRunAway