planner: re-compile query if range rebuild fails for cached plan #17090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/enhancement
ghost
requested review from
zz-jason
reviewed
May 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #17090 +/- ##
================================================
+ Coverage 79.9933% 80.0517% +0.0583%
================================================
Files 510 510
Lines 139009 139235 +226
================================================
+ Hits 111198 111460 +262
+ Misses 18844 18819 -25
+ Partials 8967 8956 -11 |
zz-jason
reviewed
May 11, 2020
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #17120 |
zz-jason
pushed a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #10111
Problem Summary:
Overflow error for unsigned handle is reported when plan cache is enabled.
What is changed and how it works?
What's Changed:
Fallback to optimizer if
rebuildRangefailed, instead of reporting error.How it Works:
This PR can avoid error for the issue case, the complete fix is differentiate user variable types.
Related changes
Check List
Tests
Side effects
N/A
Release note