-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: re-compile query if range rebuild fails f ... (#17090) #17120
Merged
zz-jason
merged 2 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-d7e492f3940d
May 12, 2020
Merged
planner: re-compile query if range rebuild fails f ... (#17090) #17120
zz-jason
merged 2 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-d7e492f3940d
May 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
sig/planner
SIG: Planner
type/4.0-cherry-pick
type/enhancement
The issue or PR belongs to an enhancement.
labels
May 12, 2020
ghost
requested a review
from eurekaka
May 12, 2020 06:58
ghost
removed their request for review
May 12, 2020 06:58
danmay319
approved these changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
approved these changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
labels
May 12, 2020
/run-all-tests |
@sre-bot merge failed. |
zz-jason
changed the title
planner: re-compile query if range rebuild fails for cached plan (#17090)
planner: re-compile query if range rebuild fails f ... (#17090)
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17090 to release-4.0
What problem does this PR solve?
Issue Number: close #10111
Problem Summary:
Overflow error for unsigned handle is reported when plan cache is enabled.
What is changed and how it works?
What's Changed:
Fallback to optimizer if
rebuildRange
failed, instead of reporting error.How it Works:
This PR can avoid error for the issue case, the complete fix is differentiate user variable types.
Related changes
Check List
Tests
Side effects
N/A
Release note