Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: re-compile query if range rebuild fails f ... (#17090) #17120

Merged
merged 2 commits into from
May 12, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 12, 2020

cherry-pick #17090 to release-4.0


What problem does this PR solve?

Issue Number: close #10111

Problem Summary:

Overflow error for unsigned handle is reported when plan cache is enabled.

What is changed and how it works?

What's Changed:

Fallback to optimizer if rebuildRange failed, instead of reporting error.

How it Works:

This PR can avoid error for the issue case, the complete fix is differentiate user variable types.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • re-compile query if range rebuild fails for cached plan

@sre-bot sre-bot requested a review from a team as a code owner May 12, 2020 06:58
@sre-bot
Copy link
Contributor Author

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot sre-bot added sig/planner SIG: Planner type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels May 12, 2020
@ghost ghost requested a review from eurekaka May 12, 2020 06:58
@ghost ghost removed their request for review May 12, 2020 06:58
@sre-bot sre-bot added this to the 4.0.0-rc.2 milestone May 12, 2020
Copy link
Contributor

@danmay319 danmay319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels May 12, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 12, 2020

@sre-bot merge failed.

@zz-jason zz-jason changed the title planner: re-compile query if range rebuild fails for cached plan (#17090) planner: re-compile query if range rebuild fails f ... (#17090) May 12, 2020
@zz-jason zz-jason merged commit 554d87a into pingcap:release-4.0 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants