Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: forbid creating a column with name _tidb_rowid #19418

Merged
merged 4 commits into from
Aug 25, 2020
Merged

ddl: forbid creating a column with name _tidb_rowid #19418

merged 4 commits into from
Aug 25, 2020

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 24, 2020 •
edited by tangenta
Loading

What problem does this PR solve?

Issue Number: close #19167, #12835

Problem Summary: According to #8126, _tidb_rowid is a reserved column. It is not likely to be useful for users. So I think it is acceptable to forbid creating such a column.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Forbid creating a column with name _tidb_rowid

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Aug 24, 2020
@xhebox

This comment has been minimized.

Sign in to view
@ti-srebot
Copy link
Contributor

/run-all-tests

@xhebox

This comment has been minimized.

Sign in to view
@ti-srebot
Copy link
Contributor

/run-unit-test

@xhebox

This comment has been minimized.

Sign in to view
@ti-srebot
Copy link
Contributor

/run-common-test

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 24, 2020
@xhebox xhebox changed the title Forbid creating a column with name _tidb_rowid ddl: forbid creating a column with name _tidb_rowid Aug 24, 2020
@xhebox

This comment has been minimized.

Sign in to view
@ti-srebot
Copy link
Contributor

/run-common-test

tangenta
tangenta reviewed Aug 25, 2020
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
djshow832
djshow832 reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2020
@djshow832 djshow832 requested a review from tangenta August 25, 2020 06:02
tangenta
tangenta reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 25, 2020
@djshow832
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 2f9b81d into pingcap:master Aug 25, 2020
@xhebox xhebox deleted the 19167 branch August 25, 2020 08:00
@bb7133 bb7133 mentioned this pull request Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@tangenta tangenta tangenta left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DML failed on table with column _tidb_rowid
4 participants
@xhebox @ti-srebot @djshow832 @tangenta