-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add a variable to control whether we can write _tidb_rowid #8126
Conversation
/run-all-tests |
I believe this might break https://github.com/pingcap/mydumper 's restore. PTAL @kennytm |
Could we have an internal flag which allows INSERT to accept a |
/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0 |
in tidb-binlog, we use _tidb_rowid to guarantee the idempotence when table's PKIsHandle is false. same with lightning and loader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @jackysp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
There are problems handling the following case:
What is changed and how it works?
At the moment, if we have to deal with _tidb_rowid, it will be more complicated. So it is best not to support inserting, updating, and replacing _tidb_rowid statements now. But we have some tools that need to write _tidb_rowid, these tools will guarantee that they will not appear as above.
Currently, we want users not to open
AllowWriteRowID
.Check List
Tests
Related changes