Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check for only_full_group_by in ORDER BY and HAVING #21216

Merged
merged 6 commits into from
Dec 14, 2020
Merged

planner: check for only_full_group_by in ORDER BY and HAVING #21216

merged 6 commits into from
Dec 14, 2020

Conversation

dyzsr
Copy link
Contributor

@dyzsr dyzsr commented Nov 23, 2020

What problem does this PR solve?

Issue Number: close #21112

Problem Summary: No check for only_full_group_by in ORDER BY and HAVING if there's no group clause.

What is changed and how it works?

  • Add check for ORDER BY and HAVING in checkOnlyFullGroupByWithOutGroupClause

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Check for only_full_group_by in ORDER BY and HAVING for query without group clause.

@dyzsr dyzsr requested a review from a team as a code owner November 23, 2020 08:34
@dyzsr dyzsr requested review from eurekaka and removed request for a team November 23, 2020 08:34
@ichn-hu ichn-hu mentioned this pull request Nov 23, 2020
Closed
@dyzsr
Copy link
Contributor Author

dyzsr commented Dec 7, 2020

/cc @lzmhhh123

lzmhhh123
lzmhhh123 reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2020
@XuHuaiyu XuHuaiyu added sig/planner SIG: Planner type/bugfix This PR fixes a bug. labels Dec 9, 2020
@dyzsr
Copy link
Contributor Author

dyzsr commented Dec 11, 2020

/run-all-tests

@b41sh
Copy link
Member

b41sh commented Dec 13, 2020

LGTM

@ti-srebot
Copy link
Contributor

@b41sh, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: planner(slack).

XuHuaiyu
XuHuaiyu approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 14, 2020
@XuHuaiyu
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 49b926e into pingcap:master Dec 14, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 14, 2020
@dyzsr @ti-srebot
cherry pick pingcap#21216 to release-4.0
8f2e926 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 14, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21697

ti-srebot added a commit that referenced this pull request Jan 26, 2021
@ti-srebot
planner: check for only_full_group_by in ORDER BY and HAVING (#21216) (…
c751241 
…#21697)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No check for only full group by after resolving having and order by
5 participants
@dyzsr @b41sh @ti-srebot @XuHuaiyu @lzmhhh123