Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check for only_full_group_by in ORDER BY and HAVING (#21216) #21697

Merged
merged 4 commits into from
Jan 26, 2021
Merged

planner: check for only_full_group_by in ORDER BY and HAVING (#21216) #21697

merged 4 commits into from
Jan 26, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21216 to release-4.0

What problem does this PR solve?

Issue Number: close #21112

Problem Summary: No check for only_full_group_by in ORDER BY and HAVING if there's no group clause.

What is changed and how it works?

  • Add check for ORDER BY and HAVING in checkOnlyFullGroupByWithOutGroupClause

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Check for only_full_group_by in ORDER BY and HAVING for query without group clause.

@dyzsr @ti-srebot
cherry pick pingcap#21216 to release-4.0
8f2e926 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 14, 2020
Merged
@ti-srebot ti-srebot added sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Dec 14, 2020
@ti-srebot ti-srebot added this to the 4.0.0 milestone Dec 14, 2020
@ti-srebot
Copy link
Contributor Author

@dyzsr you're already a collaborator in bot's repo.

lzmhhh123
lzmhhh123 reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2020
@jebter jebter modified the milestones: 4.0.0, v4.0.10 Jan 7, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
qw4990
qw4990 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 22481
  • 21628
  • 21142
  • 21936
  • 21874
  • 20981
  • 21464
  • 21483
  • 21525
  • 21590
  • 21604
  • 21614
  • 21673

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit c751241 into pingcap:release-4.0 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@qw4990 qw4990 qw4990 approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@dyzsr dyzsr

Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @qw4990 @lzmhhh123 @jebter @zz-jason @dyzsr