Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: disable list partition by default since it's an experimental feature #22045

Merged
merged 4 commits into from
Dec 29, 2020

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 28, 2020

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Disable list-partition table by default.

What is changed and how it works?

Add nightly value for tidb_enable_table_partition variable to enable list partition.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • No

Release note

  • Disable list partition by default since it's an experimental feature.

@crazycs520
Copy link
Contributor Author

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Dec 28, 2020

@crazycs520 please fix tidb-test

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1144

@crazycs520
Copy link
Contributor Author

/run-common-test tidb-test=pr/1144
/run-integration-common-test tidb-test=pr/1144

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-common-test tidb-test=pr/1144
/run-integration-common-test tidb-test=pr/1144

@crazycs520
Copy link
Contributor Author

@crazycs520
Copy link
Contributor Author

@tiancaiamao @lysu PTAL

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2020
ddl/partition.go Outdated Show resolved Hide resolved
ddl/partition.go Outdated Show resolved Hide resolved
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1144

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1144

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 28, 2020
@crazycs520 crazycs520 merged commit b1bd285 into pingcap:master Dec 29, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 29, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #22060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants