Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: use tidb_enable_list_partition to enable list table partition feature (#22864) #22957

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 25, 2021

cherry-pick #22864 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22957

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22957:release-5.0-rc-7151b4f3b5ec

What problem does this PR solve?

  1. Revert config: disable list partition by default since it's an experimental feature #22045 first.
  2. Add tidb_enable_list_partition session variable to control list table partition feature.

What is changed and how it works?

N/A

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • N/A

Release note

  • N/A

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested review from a team as code owners February 25, 2021 14:11
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team February 25, 2021 14:11
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@crazycs520 you're already a collaborator in bot's repo.

@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=pr/1165

@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=pr/1165

@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1165
/run-integration-common-test tidb-test=pr/1165

2 similar comments
@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1165
/run-integration-common-test tidb-test=pr/1165

@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1165
/run-integration-common-test tidb-test=pr/1165

@crazycs520
Copy link
Contributor

/run-integration-common-test tidb-test=pr/1165

@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1165

1 similar comment
@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1165

@crazycs520
Copy link
Contributor

/run-common-test

@crazycs520
Copy link
Contributor

/run-common-test tidb-test=release-5.0-rc

@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1166

@crazycs520
Copy link
Contributor

/run-integration-common-test tidb-test=pr/1166

@crazycs520
Copy link
Contributor

/run-common-test tidb-test=pr/1166

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2021
@tangenta
Copy link
Contributor

tangenta commented Mar 1, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2021
@jackysp
Copy link
Member

jackysp commented Mar 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@jackysp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9380b1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2021
@ti-chi-bot ti-chi-bot merged commit f41ca49 into pingcap:release-5.0-rc Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants