Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: fix wrong bucket name of coprocessor cache #22454

Merged
merged 2 commits into from
Jan 29, 2021
Merged

metrics: fix wrong bucket name of coprocessor cache #22454

merged 2 commits into from
Jan 29, 2021

Conversation

lzmhhh123
Copy link
Contributor

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Problem Summary:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • None

Release note

  • fix wrong bucket name of coprocessor cache.

@lzmhhh123
metrics: fix wrong column name of coprocessor cache
7cbe65d 
Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 20, 2021
XuHuaiyu
XuHuaiyu reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2021
wshwsh12
wshwsh12 reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@wshwsh12, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@lzmhhh123 lzmhhh123 added sig/execution SIG execution and removed sig/sql-infra SIG: SQL Infra labels Jan 29, 2021
@wshwsh12
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 29, 2021
@lzmhhh123 lzmhhh123 added needs-cherry-pick-5.0-rc status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 29, 2021
AilinKid
AilinKid reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 29, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 29, 2021
@lzmhhh123 lzmhhh123 merged commit 94fe8d9 into pingcap:master Jan 29, 2021
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_wrong_column_of_copr_cache_grafana branch January 29, 2021 03:11
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 29, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#22454 to release-4.0
e089676 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 29, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #22617

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 29, 2021
@lzmhhh123 @ti-srebot
cherry pick pingcap#22454 to release-5.0-rc
9ce04c0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 29, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #22618

ti-chi-bot pushed a commit that referenced this pull request May 12, 2021
@ti-srebot
metrics: fix wrong bucket name of coprocessor cache (#22454) (#22617)
371333c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@wshwsh12 wshwsh12 wshwsh12 left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lzmhhh123 @ti-srebot @wshwsh12 @XuHuaiyu @AilinKid