Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix wrong bucket name of coprocessor cache (#22454) #22618

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 29, 2021

cherry-pick #22454 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22618

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22618:release-5.0-rc-94fe8d954e6e

Signed-off-by: lzmhhh123 lzmhhh123@gmail.com

What problem does this PR solve?

Problem Summary:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • None

Release note

  • fix wrong bucket name of coprocessor cache.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@lzmhhh123 you're already a collaborator in bot's repo.

@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2021
@bb7133
Copy link
Member

bb7133 commented Feb 4, 2021

Close it since only the following PRs are required to cherry-pick to 5.0-rc:

  • critical bug-fixs
  • required feature changes
  • PRs to stabilize CI

@bb7133 bb7133 closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants