-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: refine performance of EXTRACT function #22701
Merged
ti-srebot
merged 19 commits into
pingcap:master
from
leiysky:enhancement/extract-datetime-from-string
Feb 19, 2021
Merged
expression: refine performance of EXTRACT function #22701
ti-srebot
merged 19 commits into
pingcap:master
from
leiysky:enhancement/extract-datetime-from-string
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for pingcap/tipb#213 |
…thub.com/leiysky/tidb into enhancement/extract-datetime-from-string
/run-all-tests |
2 similar comments
/run-all-tests |
/run-all-tests |
@lzmhhh123 PTAL |
…-datetime-from-string
…thub.com/leiysky/tidb into enhancement/extract-datetime-from-string
lzmhhh123
reviewed
Feb 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ichn-hu
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Feb 19, 2021
/merge |
/run-all-tests |
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 19, 2021
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #22700
Problem Summary:
What is changed and how it works?
What's Changed:
builtinExtractDatetimeFromStringSig
How it Works:
Related changes
Check List
Tests
Release note