Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expression signature ExtractDatetimeFromString #213

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Add expression signature ExtractDatetimeFromString #213

merged 2 commits into from
Feb 4, 2021

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Feb 3, 2021 •
edited
Loading

Related issue: pingcap/tidb#22700

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@leiysky leiysky mentioned this pull request Feb 4, 2021
Merged
@leiysky leiysky marked this pull request as ready for review February 4, 2021 05:12
@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

@lzmhhh123 PTAL

lzmhhh123
lzmhhh123 approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leiysky leiysky merged commit 2870a08 into pingcap:master Feb 4, 2021
@leiysky leiysky deleted the feature/extract-datetime-from-string branch February 4, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leiysky @CLAassistant @lzmhhh123