-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add new format specifier(%# %@ %.) for str_to_date expression (#22790) #22812
executor: add new format specifier(%# %@ %.) for str_to_date expression (#22790) #22812
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@guo-shaoge you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Sorry @AilinKid, this branch's release version is in progress, please contact zhouqiang-cl,shuke987,jebter,you06 for more details. |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 109fef2
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #22790 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22812
After apply modifications, you can push your change to this PR via:
close #22530
What's Changed: add three function to parse
How it Works: If got %# in format specifier, iterate input string and skip all number. Same for the other two.
Related changes
Check List
Tests
Side effects
Release note