Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add new format specifier(%# %@ %.) for str_to_date expression (#22790) #22813

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 19, 2021

cherry-pick #22790 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22813

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22813:release-5.0-rc-a3a4a6c4da7e

close #22530

What's Changed: add three function to parse

  1. %#: skip numbers
  2. %.: skip punct
  3. %@: skip alpha

How it Works: If got %# in format specifier, iterate input string and skip all number. Same for the other two.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression: No perfmance regression
  • Breaking backward compatibility: No compatibility issue

Release note

  • add three format specifier for str_to_date expression

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner February 19, 2021 06:59
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team February 19, 2021 06:59
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@guo-shaoge you're already a collaborator in bot's repo.

@XuHuaiyu
Copy link
Contributor

not a critical bug, do not need to cherry-pick to release-5.0-rc

@XuHuaiyu XuHuaiyu closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants