Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: remove use of SchemaLease transaction option in store/tikv #24331

Merged
merged 8 commits into from
Apr 28, 2021
Merged

store/tikv: remove use of SchemaLease transaction option in store/tikv #24331

merged 8 commits into from
Apr 28, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Usage of SchemaChecker option in store/tikv can be removed.

Part of #24302

What is changed and how it works?

What's Changed:

  • add schemaLeaseChecker in KVTxn
  • add method SetSchemaLeaseChecker to set up the checker
  • update driver.tikvTxn to adapt.

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing
store/tikv: remove SchemaLease option
4f7d608 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the sig/transaction SIG:Transaction label Apr 27, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2021
AndreMouche
AndreMouche approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

store/tikv/2pc.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2021
sticnarf
sticnarf approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But just the existence of SchemaLeaseCheck in the client is weird after we moved the whole client out of TiDB. We can change it later :)

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2021
@disksing
Copy link
Contributor Author

LGTM. But just the existence of SchemaLeaseCheck in the client is weird after we moved the whole client out of TiDB. We can change it later :)

Totally agree! I was also thinking the main subject here is the option so...

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2021
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78c41d5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2021
@tisonkun
Copy link
Contributor

this title is remove SchemaLease option but actually it is about Transaction option SchemaChecker. Also we do not remove the option. I'm confused by the title though.

@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2021
@disksing
Copy link
Contributor Author

this title is remove SchemaLease option but actually it is about Transaction option SchemaChecker. Also we do not remove the option. I'm confused by the title though.

Good point.

@disksing disksing changed the title store/tikv: remove SchemaLease option store/tikv: remove use of SchemaLease transaction option in store/tikv Apr 28, 2021
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 772598c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2021
@ti-chi-bot ti-chi-bot merged commit 75be70c into pingcap:master Apr 28, 2021
@disksing disksing deleted the options-schema-checker branch April 28, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@disksing @ti-chi-bot @tisonkun @AndreMouche @sticnarf