Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema, executor: Add the deadlock table #24524

Merged
merged 47 commits into from
May 19, 2021

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented May 10, 2021

What problem does this PR solve?

Problem Summary: As part of Lock View , there will be a new system table named DEAD_LOCK that shows information about recent several deadlock error.

What is changed and how it works?

What's Changed:

  • A module named deadlockhistory is introduced, located in the util directory like stmtsummary. It contains a global instance of a queue to collect deadlock events in FIFO manner.
  • An OnDeadlock callback is added to LockCtx, and is called at the time the deadlock error is received from TiKV but before pessimsticRollback.
  • A new table DEAD_LOCK in information schema is added to show the collected deadlock events in the TiDB node, and also a cluster version CLUSTER_DEAD_LOCK that shows deadlock information from all TiDB nodes in the cluster.
    • Each row of the DEAD_LOCK table represents one of the transactions that causes the deadlock, and rows with the same DEADLOCK_ID forms a complete deadlock event.
    • For CLUSTER_DEAD_LOCK table, rows with the same (INSTANCE, DEADLOCK_ID) forms a deadlock event since the DEADLOCK_ID is not unique among different TiDB nodes.

Note that the ALL_SQLS field in our design is not ye implemented in this PR. It relies on the TIDB_TRX table, and also the current PR is already too large.

Example:

/* init */ drop table if exists t;
-- init >> 0 rows affected
/* init */ create table t (id int primary key, v int);
-- init >> 0 rows affected
/* init */ insert into t values (1, 10), (2, 20), (3, 30);
-- init >> 3 rows affected
/* t1:wait */ begin;
-- t1 >> 0 rows affected
/* t1 */ update t set v = 11 where id = 1;
-- t1 >> 1 rows affected
/* t2 */ begin;
-- t2 >> 0 rows affected
/* t2 */ update t set v = 21 where id = 2;
-- t2 >> 1 rows affected
/* t1:wait */ update t set v = 12 where id = 2;
-- t1 >> blocked
/* t2 */ update t set v = 22 where id = 1;
-- t2 >> E1213: Deadlock found when trying to get lock; try restarting transaction
-- t1 >> resumed
-- t1 >> 1 rows affected
/* t1 */ rollback;
-- t1 >> 0 rows affected
/* t2 */ rollback;
-- t2 >> 0 rows affected
/* t3:wait */ select * from information_schema.deadlocks;
-- t3 >> +-------------+----------------------------+-----------+--------------------+------------------------------------------------------------------+----------------------------------------+----------+--------------------+
-- t3    | DEADLOCK ID |         OCCUR TIME         | RETRYABLE |  TRY LOCK TRX ID   |                        CURRENT SQL DIGEST                        |                  KEY                   | ALL SQLS |  TRX HOLDING LOCK  |
-- t3    +-------------+----------------------------+-----------+--------------------+------------------------------------------------------------------+----------------------------------------+----------+--------------------+
-- t3    |           1 | 2021-05-19 10:48:09.567305 |         0 | 425045860169023490 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000002 | NULL     | 425045860169023491 |
-- t3    |           1 | 2021-05-19 10:48:09.567305 |         0 | 425045860169023491 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000001 | NULL     | 425045860169023490 |
-- t3    +-------------+----------------------------+-----------+--------------------+------------------------------------------------------------------+----------------------------------------+----------+--------------------+
/* t3:wait */ select l.deadlock_id, l.occur_time, l.try_lock_trx_id, l.trx_holding_lock, s.digest_text from information_schema.deadlocks as l left join information_schema.statements_summary as s on l.current_sql_digest = s.digest;
-- t3 >> +-------------+----------------------------+--------------------+--------------------+-----------------------------------------+
-- t3    | DEADLOCK ID |         OCCUR TIME         |  TRY LOCK TRX ID   |  TRX HOLDING LOCK  |               DIGEST TEXT               |
-- t3    +-------------+----------------------------+--------------------+--------------------+-----------------------------------------+
-- t3    |           1 | 2021-05-19 10:48:09.567305 | 425045860169023490 | 425045860169023491 | update `t` set `v` = ? where `id` = ? ; |
-- t3    |           1 | 2021-05-19 10:48:09.567305 | 425045860169023491 | 425045860169023490 | update `t` set `v` = ? where `id` = ? ; |
-- t3    +-------------+----------------------------+--------------------+--------------------+-----------------------------------------+
/* t1:wait */ begin;
-- t1 >> 0 rows affected
/* t1 */ update t set v = 11 where id = 1;
-- t1 >> 1 rows affected
/* t2 */ begin;
-- t2 >> 0 rows affected
/* t2 */ update t set v = 21 where id = 2;
-- t2 >> 1 rows affected
/* t3 */ begin;
-- t3 >> 0 rows affected
/* t3 */ update t set v = 31 where id = 3;
-- t3 >> 1 rows affected
/* t1:wait */ update t set v = 12 where id = 2;
-- t1 >> blocked
/* t2 */ update t set v = 22 where id = 3;
-- t2 >> blocked
/* t3 */ update t set v = 32 where id = 1;
-- t3 >> E1213: Deadlock found when trying to get lock; try restarting transaction
-- t2 >> resumed
-- t2 >> 1 rows affected
/* t2 */ rollback;
-- t2 >> 0 rows affected
-- t1 >> resumed
-- t1 >> 1 rows affected
/* t1 */ rollback;
-- t1 >> 0 rows affected
/* t3 */ rollback;
-- t3 >> 0 rows affected
/* t4:wait */ select * from information_schema.deadlocks;
-- t4 >> +-------------+----------------------------+-----------+--------------------+------------------------------------------------------------------+----------------------------------------+----------+--------------------+
-- t4    | DEADLOCK ID |         OCCUR TIME         | RETRYABLE |  TRY LOCK TRX ID   |                        CURRENT SQL DIGEST                        |                  KEY                   | ALL SQLS |  TRX HOLDING LOCK  |
-- t4    +-------------+----------------------------+-----------+--------------------+------------------------------------------------------------------+----------------------------------------+----------+--------------------+
-- t4    |           1 | 2021-05-19 10:48:09.567305 |         0 | 425045860169023490 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000002 | NULL     | 425045860169023491 |
-- t4    |           1 | 2021-05-19 10:48:09.567305 |         0 | 425045860169023491 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000001 | NULL     | 425045860169023490 |
-- t4    |           2 | 2021-05-19 10:48:27.592010 |         0 | 425045862528319493 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000002 | NULL     | 425045862528319494 |
-- t4    |           2 | 2021-05-19 10:48:27.592010 |         0 | 425045862528319494 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000003 | NULL     | 425045862528319495 |
-- t4    |           2 | 2021-05-19 10:48:27.592010 |         0 | 425045862528319495 | 22230766411edb40f27a68dadefc63c6c6970d5827f1e5e22fc97be2c4d8350d | 7480000000000000355F728000000000000001 | NULL     | 425045862528319493 |
-- t4    +-------------+----------------------------+-----------+--------------------+------------------------------------------------------------------+----------------------------------------+----------+--------------------+
/* t4:wait */ select l.deadlock_id, l.occur_time, l.try_lock_trx_id, l.trx_holding_lock, s.digest_text from information_schema.deadlocks as l left join information_schema.statements_summary as s on l.current_sql_digest = s.digest;
-- t4 >> +-------------+----------------------------+--------------------+--------------------+-----------------------------------------+
-- t4    | DEADLOCK ID |         OCCUR TIME         |  TRY LOCK TRX ID   |  TRX HOLDING LOCK  |               DIGEST TEXT               |
-- t4    +-------------+----------------------------+--------------------+--------------------+-----------------------------------------+
-- t4    |           1 | 2021-05-19 10:48:09.567305 | 425045860169023490 | 425045860169023491 | update `t` set `v` = ? where `id` = ? ; |
-- t4    |           1 | 2021-05-19 10:48:09.567305 | 425045860169023491 | 425045860169023490 | update `t` set `v` = ? where `id` = ? ; |
-- t4    |           2 | 2021-05-19 10:48:27.592010 | 425045862528319493 | 425045862528319494 | update `t` set `v` = ? where `id` = ? ; |
-- t4    |           2 | 2021-05-19 10:48:27.592010 | 425045862528319494 | 425045862528319495 | update `t` set `v` = ? where `id` = ? ; |
-- t4    |           2 | 2021-05-19 10:48:27.592010 | 425045862528319495 | 425045862528319493 | update `t` set `v` = ? where `id` = ? ; |
-- t4    +-------------+----------------------------+--------------------+--------------------+-----------------------------------------+

Related changes

Check List

Tests

  • Unit test (TODO)
  • Integration test (TODO)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • Adds table DEAD_LOCK and CLUSTER_DEAD_LOCK table that provides information about recent several deadlock events

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 10, 2021
@MyonKeminta MyonKeminta mentioned this pull request May 10, 2021
20 tasks
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels May 10, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2021
@MyonKeminta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 816a573

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2021
@MyonKeminta
Copy link
Contributor Author

/run-integration-ddl-test
/run-unit-test

@MyonKeminta
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented May 19, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@MyonKeminta MyonKeminta changed the title infoschema: Add the deadlock table infoschema, executor: Add the deadlock table May 19, 2021
@ti-chi-bot
Copy link
Member

@MyonKeminta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3904ca3 into pingcap:master May 19, 2021
@MyonKeminta MyonKeminta deleted the m/deadlock-table branch May 20, 2021 04:37
Howie59 pushed a commit to Howie59/tidb that referenced this pull request May 21, 2021
…ingcap#24052)

* *: fix revoke statement for CURRENT_USER() and refine error message

planner: support set tidb_allow_mpp to `2` or `ENFORCE` to enforce use mpp mode. (pingcap#24516)

store/tikv: remove use of SchemaAmender option in store/tikv (pingcap#24408)

*: the value of tikv-client.store-liveness-timeout should not less than 0 (pingcap#24244)

store/tikv: remove use of EnableAsyncCommit option in store/tikv (pingcap#24462)

txn: Add txn state's view (pingcap#22908)

planner: ignore lock for temporary table of PointGet and BatchPointGet (pingcap#24540)

store/tikv: remove use of ReplicaRead transaction option in store/tikv (pingcap#24409)

store/driver: move error to single package (pingcap#24549)

ddl: add check table compatibility for temporary table (pingcap#24501)

store/tikv: remove use of IsStatenessReadOnly option in store/tikv (pingcap#24464)

store/tikv: change backoff type for missed tiflash peer. (pingcap#24577)

store/tikv: remove use of MatchStoreLabels transaction option in store/tikv (pingcap#24465)

executor, meta: Allocate auto id for global temporary tables (pingcap#24506)

store/tikv: remove use of SampleStep option in store/tikv (pingcap#24461)

executor: add partition pruning tests for adding and dropping partition operations (pingcap#24573)

ddl: forbid partition on temporary mode before put into queue (pingcap#24565)

ddl: speedup test case TestIndexOnMultipleGeneratedColumn (pingcap#24487)

execution: Fix issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* (pingcap#24485)

*: fix errcheck (pingcap#24463)

test: make TestExtractStartTs stable (pingcap#24585)

ddl: forbid recover/flashback temporary tables (pingcap#24518)

executor: fix point_get result on clustered index when new-row-format disabled but new-collation enabled (pingcap#24544)

executor: Improve the performance of appending not fixed columns (pingcap#20969)

*: typo fix (pingcap#24564)

planner/core: refresh stale regions in cache for batch cop response (pingcap#24457)

binlog: DML on temporary tables do not write binlog (pingcap#24570)

store/tikv: remove use of GuaranteeLinearizability option in store/tikv (pingcap#24605)

store/tikv: remove use of CollectRuntimeStats option in store/tikv (pingcap#24604)

store/tikv: move Backoffer into a single package (pingcap#24525)

variables: init cte max recursive deeps in a new session (pingcap#24609)

store/tikv: move transaction options out to /kv (pingcap#24619)

store/driver: move backoff driver into single package so we can use i… (pingcap#24624)

server: close the temporary session in HTTP API to avoid memory leak (pingcap#24339)

store/tikv: use latest PD TS plus one as min commit ts (pingcap#24579)

planner: fix incorrect TableDual plan built from nulleq (pingcap#24596)

ranger: fix the case which could have duplicate ranges (pingcap#24590)

 executor, store: Pass the SQL digest down to pessimistic lock request (pingcap#24380)

kv: remove UnionStore interface (pingcap#24625)

*: enable gosimple linter (pingcap#24617)

txn: avoid the gc resolving pessimistic locks of ongoing transactions (pingcap#24601)

util: fix wrong enum building for index range  (pingcap#24632)

sessionctx: change innodb large prefix default (pingcap#24555)

store: fix data race about KVStore.tikvClient (pingcap#24655)

executor, privileges: Add dynamic privileges to SHOW PRIVILEGES (pingcap#24646)

ddl: refactor rule [4/6] (pingcap#24007)

cmd: ddl_test modify retryCnt from 5 to 20 (pingcap#24662)

executor: add correctness tests about direct reading with ORDER BY and LIMIT (pingcap#24455)

store/tikv: remove options from unionstore (pingcap#24629)

planner: fix wrongly check for update statement (pingcap#24614)

store/tikv: remove CompareTS (pingcap#24657)

planner, privilege: Add security enhanced mode part 4 (pingcap#24416)

executor: add some test cases about partition table dynamic-mode with split-region (pingcap#24665)

planner: fix wrong column offsets when processing dynamic pruning for IndexJoin (pingcap#24659)

*: Add security enhanced mode part 3 (pingcap#24412)

store/tikv: resolve ReplicaReadType dependencies (pingcap#24653)

executor: add test cases about partition table with `expression` (pingcap#24628)

tablecodec: fix write wrong prefix index value when collation is ascii_bin/latin1_bin (pingcap#24578)

*: compatibility with staleread (pingcap#24285)

session: test that temporary tables will also be retried (pingcap#24505)

domain, session: Add new sysvarcache to replace global values cache (pingcap#24359)

ddl, transaction: DDL on temporary tables won't affect transactions (pingcap#24534)

*: implement tidb_bounded_staleness built-in function (pingcap#24328)

executor: add correctness tests for partition table with different joins (pingcap#24673)

expression: fix the spelling of word arithmetical (pingcap#24713)

store/copr: balance region for batch cop task (pingcap#24521)

store, metrics: Add metrics for safetTS updating (pingcap#24687)

sem: add tidbredact log to restricted variables (pingcap#24701)

session: fix dml_batch_size doesn't load the global variable (pingcap#24710)

store/tikv: retry TSO RPC (pingcap#24682)

expression, planner: push cast down to control function with enum type. (pingcap#24542)

executor: add correctness tests about IndexMerge (pingcap#24674)

variable: change default for DefDMLBatchSize tidbOptInt64 call (pingcap#24697)

planner: add partitioning pruning tests for range partitioning (pingcap#24554)

*: add option for enum push down (pingcap#24685)

txn: break dependency from store/tikv to tidb/kv cause by TransactionOption (pingcap#24656)

executor: enhancement for ListInDisk(support writing after reading) (pingcap#24379)

kv: move TxnScope into kv (pingcap#24715)

execution: fix the incorrect use of cached plan for point get (pingcap#24749)

executor: add correctness tests about direct reading with indexJoin (pingcap#24497)

variable:  fix sysvar datarace with deep copy (pingcap#24732)

*: Implementing RENAME USER (pingcap#24413)

infoschema, executor: Add the deadlock table (pingcap#24524)

docs: Some proposal for renaming and configurations for Lock View (pingcap#24718)

planner: add range partition boundaries tests with BETWEEN expression (pingcap#24598)

oracle: simplify timestamp utilities (pingcap#24688)

executor: fix wrong enum key in point get (pingcap#24618)

ranger: fix incorrect enum range for xxx_ci collation (pingcap#24661)

executor: add some test cases about dynamic-mode and apply operator (pingcap#24683)

store/tikv: remove Variables.Hook (pingcap#24758)

ddl: speed up the execution time of `TestBackwardCompatibility`. (pingcap#24704)

*: prepare errors for CTE (pingcap#24763)

expression: support cast real/int as real (pingcap#24670)

executor: add table name in log (pingcap#24666)

expression: add builtin function ``json_pretty`` (pingcap#24675)

ddl: make `TestDropLastVisibleColumns` stable (pingcap#24790)

* ddl: make `TestDropLastVisibleColumns` stable

*: support AS OF TIMESTAMP read-only begin statement (pingcap#24740)

executor: Fix unstable TestTiDBLastTxnInfoCommitMode (pingcap#24779)

planner: add tests for partition range boundaries for LT/GT (pingcap#24574)

test: record random seed in TestIssue20658 (pingcap#24782)

store/tikv/retry: define Config instead of BackoffType (pingcap#24692)

config: ignore tiflash when show config (pingcap#24770)

privileges: improve dynamic privs registration and tests (pingcap#24773)

README: remove the link of TiDB Monthly Update (pingcap#24791)

region_cache: filter peers on tombstone or dropped stores (pingcap#24726)

util/stmtsummary: remove import package tikv (pingcap#24776)

ddl: grammar check for create unsupported temporary table (pingcap#24723)

*: update go.etcd.io/bbolt (pingcap#24799)

ddl: speed up the execution time of `ddl test` and `Test Chunk pingcap#7 ddl-other` (pingcap#24780)

executor: remove the unnecessary use of fmt.Sprintf (pingcap#24815)

executor: fix index join panic on prefix index on some cases (pingcap#24568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants