docs: Some proposal for renaming and configurations for Lock View #24718

MyonKeminta · 2021-05-18T07:40:50Z

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

What problem does this PR solve?

Problem Summary: This PR patches the design doc for Lock VIew where I think there's some improper naming and missing informations.

What is changed and how it works?

What's Changed:

Renaming DEAD_LOCK to DEADLOCKS
Renaming SQLS field to ALL_SQLS
Add configuration about deadlock information collecting
Add RETRYABLE field to DEADLOCKS table
Add explanation about retryable and non-retryable deadlocks.

Related changes

Check List

Tests

No code

Side effects

Release note

No release note

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

cfzjywxk · 2021-05-18T07:44:51Z

docs/design/2021-04-26-lock-view.md

@@ -151,9 +155,23 @@ The locking key and `resource_group_tag` that comes from the `Context` of the pe

 The wait chain will be added to the `Deadlock` error which is returned by the `PessimisticLock` request, so that when deadlock happens, the full wait chain information can be passed to TiDB.

+### Configurations


Maybe some background HTTP API could be used, currently, we need to be careful adding system variables as there are already many and once released we can't take them back.

MyonKeminta · 2021-05-18T08:45:26Z

docs/design/2021-04-26-lock-view.md

+Value: 0 to 10000
+Default: 10
+
+#### TiDB Config File `pessimistic-txn.tidb_deadlock_history_collect_retryable`


This will be a low priority development task and perhaps out of this sprint, depending on the time.

MyonKeminta · 2021-05-18T09:03:53Z

docs/design/2021-04-26-lock-view.md

+| `TRX_ID`    | `unsigned bigint`   | The transaction ID (aka. start ts) |
+| `TRX_STARTED`|`time`| Human readable start time of the transaction |
+| `DIGEST`|`text`| The digest of the current executing SQL statement |
+| `ALL_SQLS` | `text` | A list of all executed SQL statements' digests |


The original SQLS doesn't looks understandable.
Maybe ALL_SQLS is still kind of confusing. Maybe it's better to name it something like ALL_SQL_DIGESTS, FINISHED_SQL_DIGESTS 🤔

This might be too big for this sprint, but:
Would it be better if we make them a seperated table? eg. TRX_STATEMENT.

Field Type Comment

TRX_ID unsigned bigint

digest text

index int This sql is the index-th statement in this transaction

And we can probably add more fields here, eg. each statements's execution time, etc.

It looks logically correct to split it to another table, but I'm afraid it's too complicated, and it would be hard to get consistent data from this table and TIDB_TRX when the user wants to join them. It would also be kind of difficult to attach the information to the DEADLOCK table like how we designed before.
What's your opinion? @youjiali1995 @cfzjywxk

By the way, I think we need to implement it in this sprint since we've planed so. Actually, I'm about to start trying it.

Currenly maybe we could do it in the simple way.

longfangsong

/lgtm

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

cfzjywxk

/lgtm

ti-chi-bot · 2021-05-19T10:26:11Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

cfzjywxk
longfangsong

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

MyonKeminta · 2021-05-19T10:45:33Z

/merge

ti-chi-bot · 2021-05-19T10:45:35Z

This pull request has been accepted and is ready to merge.

Commit hash: 9f839ed

ti-chi-bot · 2021-05-19T13:55:53Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

purelind · 2021-05-19T14:04:08Z

/run-build

ti-chi-bot · 2021-05-19T15:59:54Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-19T17:42:10Z

@MyonKeminta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…ingcap#24052) * *: fix revoke statement for CURRENT_USER() and refine error message planner: support set tidb_allow_mpp to `2` or `ENFORCE` to enforce use mpp mode. (pingcap#24516) store/tikv: remove use of SchemaAmender option in store/tikv (pingcap#24408) *: the value of tikv-client.store-liveness-timeout should not less than 0 (pingcap#24244) store/tikv: remove use of EnableAsyncCommit option in store/tikv (pingcap#24462) txn: Add txn state's view (pingcap#22908) planner: ignore lock for temporary table of PointGet and BatchPointGet (pingcap#24540) store/tikv: remove use of ReplicaRead transaction option in store/tikv (pingcap#24409) store/driver: move error to single package (pingcap#24549) ddl: add check table compatibility for temporary table (pingcap#24501) store/tikv: remove use of IsStatenessReadOnly option in store/tikv (pingcap#24464) store/tikv: change backoff type for missed tiflash peer. (pingcap#24577) store/tikv: remove use of MatchStoreLabels transaction option in store/tikv (pingcap#24465) executor, meta: Allocate auto id for global temporary tables (pingcap#24506) store/tikv: remove use of SampleStep option in store/tikv (pingcap#24461) executor: add partition pruning tests for adding and dropping partition operations (pingcap#24573) ddl: forbid partition on temporary mode before put into queue (pingcap#24565) ddl: speedup test case TestIndexOnMultipleGeneratedColumn (pingcap#24487) execution: Fix issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* (pingcap#24485) *: fix errcheck (pingcap#24463) test: make TestExtractStartTs stable (pingcap#24585) ddl: forbid recover/flashback temporary tables (pingcap#24518) executor: fix point_get result on clustered index when new-row-format disabled but new-collation enabled (pingcap#24544) executor: Improve the performance of appending not fixed columns (pingcap#20969) *: typo fix (pingcap#24564) planner/core: refresh stale regions in cache for batch cop response (pingcap#24457) binlog: DML on temporary tables do not write binlog (pingcap#24570) store/tikv: remove use of GuaranteeLinearizability option in store/tikv (pingcap#24605) store/tikv: remove use of CollectRuntimeStats option in store/tikv (pingcap#24604) store/tikv: move Backoffer into a single package (pingcap#24525) variables: init cte max recursive deeps in a new session (pingcap#24609) store/tikv: move transaction options out to /kv (pingcap#24619) store/driver: move backoff driver into single package so we can use i… (pingcap#24624) server: close the temporary session in HTTP API to avoid memory leak (pingcap#24339) store/tikv: use latest PD TS plus one as min commit ts (pingcap#24579) planner: fix incorrect TableDual plan built from nulleq (pingcap#24596) ranger: fix the case which could have duplicate ranges (pingcap#24590) executor, store: Pass the SQL digest down to pessimistic lock request (pingcap#24380) kv: remove UnionStore interface (pingcap#24625) *: enable gosimple linter (pingcap#24617) txn: avoid the gc resolving pessimistic locks of ongoing transactions (pingcap#24601) util: fix wrong enum building for index range (pingcap#24632) sessionctx: change innodb large prefix default (pingcap#24555) store: fix data race about KVStore.tikvClient (pingcap#24655) executor, privileges: Add dynamic privileges to SHOW PRIVILEGES (pingcap#24646) ddl: refactor rule [4/6] (pingcap#24007) cmd: ddl_test modify retryCnt from 5 to 20 (pingcap#24662) executor: add correctness tests about direct reading with ORDER BY and LIMIT (pingcap#24455) store/tikv: remove options from unionstore (pingcap#24629) planner: fix wrongly check for update statement (pingcap#24614) store/tikv: remove CompareTS (pingcap#24657) planner, privilege: Add security enhanced mode part 4 (pingcap#24416) executor: add some test cases about partition table dynamic-mode with split-region (pingcap#24665) planner: fix wrong column offsets when processing dynamic pruning for IndexJoin (pingcap#24659) *: Add security enhanced mode part 3 (pingcap#24412) store/tikv: resolve ReplicaReadType dependencies (pingcap#24653) executor: add test cases about partition table with `expression` (pingcap#24628) tablecodec: fix write wrong prefix index value when collation is ascii_bin/latin1_bin (pingcap#24578) *: compatibility with staleread (pingcap#24285) session: test that temporary tables will also be retried (pingcap#24505) domain, session: Add new sysvarcache to replace global values cache (pingcap#24359) ddl, transaction: DDL on temporary tables won't affect transactions (pingcap#24534) *: implement tidb_bounded_staleness built-in function (pingcap#24328) executor: add correctness tests for partition table with different joins (pingcap#24673) expression: fix the spelling of word arithmetical (pingcap#24713) store/copr: balance region for batch cop task (pingcap#24521) store, metrics: Add metrics for safetTS updating (pingcap#24687) sem: add tidbredact log to restricted variables (pingcap#24701) session: fix dml_batch_size doesn't load the global variable (pingcap#24710) store/tikv: retry TSO RPC (pingcap#24682) expression, planner: push cast down to control function with enum type. (pingcap#24542) executor: add correctness tests about IndexMerge (pingcap#24674) variable: change default for DefDMLBatchSize tidbOptInt64 call (pingcap#24697) planner: add partitioning pruning tests for range partitioning (pingcap#24554) *: add option for enum push down (pingcap#24685) txn: break dependency from store/tikv to tidb/kv cause by TransactionOption (pingcap#24656) executor: enhancement for ListInDisk(support writing after reading) (pingcap#24379) kv: move TxnScope into kv (pingcap#24715) execution: fix the incorrect use of cached plan for point get (pingcap#24749) executor: add correctness tests about direct reading with indexJoin (pingcap#24497) variable: fix sysvar datarace with deep copy (pingcap#24732) *: Implementing RENAME USER (pingcap#24413) infoschema, executor: Add the deadlock table (pingcap#24524) docs: Some proposal for renaming and configurations for Lock View (pingcap#24718) planner: add range partition boundaries tests with BETWEEN expression (pingcap#24598) oracle: simplify timestamp utilities (pingcap#24688) executor: fix wrong enum key in point get (pingcap#24618) ranger: fix incorrect enum range for xxx_ci collation (pingcap#24661) executor: add some test cases about dynamic-mode and apply operator (pingcap#24683) store/tikv: remove Variables.Hook (pingcap#24758) ddl: speed up the execution time of `TestBackwardCompatibility`. (pingcap#24704) *: prepare errors for CTE (pingcap#24763) expression: support cast real/int as real (pingcap#24670) executor: add table name in log (pingcap#24666) expression: add builtin function ``json_pretty`` (pingcap#24675) ddl: make `TestDropLastVisibleColumns` stable (pingcap#24790) * ddl: make `TestDropLastVisibleColumns` stable *: support AS OF TIMESTAMP read-only begin statement (pingcap#24740) executor: Fix unstable TestTiDBLastTxnInfoCommitMode (pingcap#24779) planner: add tests for partition range boundaries for LT/GT (pingcap#24574) test: record random seed in TestIssue20658 (pingcap#24782) store/tikv/retry: define Config instead of BackoffType (pingcap#24692) config: ignore tiflash when show config (pingcap#24770) privileges: improve dynamic privs registration and tests (pingcap#24773) README: remove the link of TiDB Monthly Update (pingcap#24791) region_cache: filter peers on tombstone or dropped stores (pingcap#24726) util/stmtsummary: remove import package tikv (pingcap#24776) ddl: grammar check for create unsupported temporary table (pingcap#24723) *: update go.etcd.io/bbolt (pingcap#24799) ddl: speed up the execution time of `ddl test` and `Test Chunk pingcap#7 ddl-other` (pingcap#24780) executor: remove the unnecessary use of fmt.Sprintf (pingcap#24815) executor: fix index join panic on prefix index on some cases (pingcap#24568)

patch lockview design

b7419f3

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

MyonKeminta added component/docs sig/transaction SIG:Transaction labels May 18, 2021

MyonKeminta requested review from cfzjywxk and longfangsong May 18, 2021 07:40

ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 18, 2021

cfzjywxk reviewed May 18, 2021

View reviewed changes

Avoid introducing system variable

5515854

MyonKeminta commented May 18, 2021

View reviewed changes

This was referenced May 18, 2021

Implement Lock View (Sprint 3) #24199

Closed

infoschema, executor: Add the deadlock table #24524

Merged

longfangsong approved these changes May 19, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2021

MyonKeminta added 2 commits May 19, 2021 12:51

Rename values of isolation level

0ffce46

Reorder the columns of the deadlocks table

9f839ed

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

cfzjywxk approved these changes May 19, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2021

Merge branch 'master' into m/patch-lockview-design

e36ccc4

Merge branch 'master' into m/patch-lockview-design

12b6f4f

Merge branch 'master' into m/patch-lockview-design

e6e66af

Merge branch 'master' into m/patch-lockview-design

082b360

Merge branch 'master' into m/patch-lockview-design

4111bc8

ti-chi-bot merged commit 9fe83e7 into pingcap:master May 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Some proposal for renaming and configurations for Lock View #24718

docs: Some proposal for renaming and configurations for Lock View #24718

MyonKeminta commented May 18, 2021

cfzjywxk May 18, 2021

MyonKeminta May 18, 2021

MyonKeminta May 18, 2021

longfangsong May 19, 2021 •

edited

Loading

MyonKeminta May 19, 2021

cfzjywxk May 19, 2021

longfangsong left a comment

cfzjywxk left a comment

ti-chi-bot commented May 19, 2021

MyonKeminta commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

purelind commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

		@@ -151,9 +155,23 @@ The locking key and `resource_group_tag` that comes from the `Context` of the pe

		The wait chain will be added to the `Deadlock` error which is returned by the `PessimisticLock` request, so that when deadlock happens, the full wait chain information can be passed to TiDB.

		### Configurations

Field	Type	Comment
TRX_ID	unsigned bigint
digest	text
index	int	This sql is the `index`-th statement in this transaction

docs: Some proposal for renaming and configurations for Lock View #24718

docs: Some proposal for renaming and configurations for Lock View #24718

Conversation

MyonKeminta commented May 18, 2021

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

cfzjywxk May 18, 2021

Choose a reason for hiding this comment

MyonKeminta May 18, 2021

Choose a reason for hiding this comment

MyonKeminta May 18, 2021

Choose a reason for hiding this comment

longfangsong May 19, 2021 • edited Loading

Choose a reason for hiding this comment

MyonKeminta May 19, 2021

Choose a reason for hiding this comment

cfzjywxk May 19, 2021

Choose a reason for hiding this comment

longfangsong left a comment

Choose a reason for hiding this comment

cfzjywxk left a comment

Choose a reason for hiding this comment

ti-chi-bot commented May 19, 2021

MyonKeminta commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

purelind commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

longfangsong May 19, 2021 •

edited

Loading