executor: avoid distsql request for TableReader/IndexReader/IndexLookup on temporary table #24769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up on temporary table
ti-chi-bot
added
the
size/L
|
PTAL @djshow832 @qw4990 |
qw4990
reviewed
May 25, 2021
| @@ -196,6 +196,10 @@ type IndexReaderExecutor struct { | |||
|
|
|||
| // Close clears all resources hold by current object. | |||
| func (e *IndexReaderExecutor) Close() error { | |||
| if e.table != nil && e.table.Meta().TempTableType != model.TempTableNone { | |||
There was a problem hiding this comment.
How about implementing a new function in table/table.go for the logic about checking whether the table is a TmpTable?
There was a problem hiding this comment.
In general, we do not need to check e.table != nil.
It's special here because a test case construct the IndexReaderExecutor manually and don't set e.table field.
The remain part is e.table.Meta().TempTableType != model.TempTableNone.
Define a one line function for that does not seems beneficial: the change will introduce a new exported function without simplifying the code much.
qw4990
reviewed
May 25, 2021
qw4990
approved these changes
May 25, 2021
|
Please refer the pull request to its issue #24169 and it would be better if we create a dedicated sub-issue for this pr. |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
ti-chi-bot
added
the
status/can-merge
A data race is detected... I need to fix it. |
|
/merge cancel |
ti-chi-bot
removed
the
status/can-merge
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: daaf042
|
ti-chi-bot
added
the
status/can-merge
|
/run-integration-ddl-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
For the global temporary table, we use
UnionScanon an empty table to read the data.The temporary table data are actually stored in the transaction's membuffer.
Before this PR, although the result is always empty, we still send the distsql requests to the TiKV.
This PR is an optimization to avoid that.
What is changed and how it works?
What's Changed:
Do not send distsql request for TableReader/IndexReader/IndexLookup on temporary table
How it Works:
After the
kvrange is calculated, return immediately, without sending distsql request or fetching the result.Check List
Tests
Release note