-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: avoid distsql request for TableReader/IndexReader/IndexLookup on temporary table #24769
Merged
+124
−11
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6b2555d
executor: avoid distsql request for TableReader/IndexReader/IndexLook…
tiancaiamao 21ed1ab
fix CI
tiancaiamao 7f9f66e
fix CI
tiancaiamao 651b368
Merge branch 'master' into temporary-no-network
tiancaiamao a05ad8f
fix CI
tiancaiamao d947cbe
go mod tidy
tiancaiamao 9fe06b0
Merge branch 'master' into temporary-no-network
tiancaiamao fdab57a
address comment
tiancaiamao 35f032a
Merge branch 'master' into temporary-no-network
crazycs520 55c3f98
Merge branch 'master' into temporary-no-network
ti-chi-bot 8e2133e
Merge branch 'master' into temporary-no-network
ti-chi-bot c248fc5
Merge branch 'master' into temporary-no-network
ti-chi-bot daaf042
fix a data race
tiancaiamao 0b1336a
Merge branch 'master' into temporary-no-network
ti-chi-bot 1affd2e
Merge branch 'master' into temporary-no-network
ti-chi-bot 351cc8c
Merge branch 'master' into temporary-no-network
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about implementing a new function in
table/table.go
for the logic about checking whether the table is a TmpTable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we do not need to check
e.table != nil
.It's special here because a test case construct the
IndexReaderExecutor
manually and don't sete.table
field.The remain part is
e.table.Meta().TempTableType != model.TempTableNone
.Define a one line function for that does not seems beneficial: the change will introduce a new exported function without simplifying the code much.