Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: generate correct number of rows when all agg funcs are pruned #24937

Merged
merged 9 commits into from
Jun 2, 2021
Merged

planner: generate correct number of rows when all agg funcs are pruned #24937

merged 9 commits into from
Jun 2, 2021

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #24865

Problem Summary:

Wrong query result.

What is changed and how it works?

What's Changed:
If all aggregation funcs are pruned during logical optimization, keep a count(1) instead of first_row(1) if the original LogicalAggregation contains agg funcs other than first_row().

How it Works:
See the code comments for explanations.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Generate correct number of rows when all agg funcs are pruned

@eurekaka eurekaka requested a review from a team as a code owner May 27, 2021 11:36
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2021
@ichn-hu ichn-hu mentioned this pull request May 27, 2021
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2021
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a424bdf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2021
@ti-chi-bot ti-chi-bot merged commit ad7102c into pingcap:master Jun 2, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 2, 2021
@eurekaka @ti-srebot
cherry pick pingcap#24937 to release-5.0
d9e3af0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 2, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25062

ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-srebot
planner: generate correct number of rows when all agg funcs are pruned (
7ac0ec2 
#24937) (#25062)
@eurekaka eurekaka deleted the agg_prune branch June 29, 2021 11:42
@lzmhhh123
Copy link
Contributor

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Jul 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26039

eurekaka added a commit to ti-srebot/tidb that referenced this pull request Jul 14, 2021
@eurekaka
cherry pick pingcap#24937 to release-4.0
b5bc5e6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2021
@ti-srebot
planner: generate correct number of rows when all agg funcs are pruned (
eb80993 
#24937) (#26039)
@lcwangchao lcwangchao mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
6 participants
@eurekaka @ti-chi-bot @qw4990 @ti-srebot @lzmhhh123 @winoros