-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: generate correct number of rows when all agg funcs are pruned (#24937) #26039
planner: generate correct number of rows when all agg funcs are pruned (#24937) #26039
Conversation
/run-all-tests |
@eurekaka you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eurekaka Please resolve conflicts.
a55d0c5
to
c355922
Compare
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
c355922
to
b5bc5e6
Compare
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b5bc5e6
|
cherry-pick #24937 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26039
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #24865
Problem Summary:
Wrong query result.
What is changed and how it works?
What's Changed:
If all aggregation funcs are pruned during logical optimization, keep a
count(1)
instead offirst_row(1)
if the original LogicalAggregation contains agg funcs other thanfirst_row()
.How it Works:
See the code comments for explanations.
Related changes
Check List
Tests
Side effects
N/A
Release note