Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: support union all for mpp. (#24287) #25051

Merged
merged 11 commits into from
Jun 21, 2021
Merged

planner/core: support union all for mpp. (#24287) #25051

merged 11 commits into from
Jun 21, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 2, 2021 •
edited
Loading

cherry-pick #24287 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25051

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25051:release-5.0-52e89cb8bfba

What problem does this PR solve?

Problem Summary:
Support union all operator push down

What is changed and how it works?

Proposal: proposal of union all

What's Changed:
multiplying tasks during buidling mpp tasks.

Related changes

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

  • planner/core: support union all for mpp.

@hanfei1991 @ti-srebot
cherry pick pingcap#24287 to release-5.0
bc676ea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested review from a team as code owners June 2, 2021 06:16
@ti-srebot ti-srebot requested review from qw4990 and removed request for a team June 2, 2021 06:16
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jun 2, 2021
Merged
@ti-srebot ti-srebot added component/expression sig/execution SIG execution sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 2, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 2, 2021
@ti-srebot
Copy link
Contributor Author

@hanfei1991 you're already a collaborator in bot's repo.

@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 02:00
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
xiongjiwei
xiongjiwei approved these changes Jun 18, 2021
View reviewed changes
expression/column.go
return &CorrelatedColumn{
Column: col.Column,
Data: &d,
Data: col.Data,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change may cause the data race in ParallelNestedLoopApplyExec, which should fix later

@ti-chi-bot
Copy link
Member

@xiongjiwei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xiongjiwei
Copy link
Contributor

/run-check_dev

@hanfei1991
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@hanfei1991: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@hanfei1991
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f03ae8f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@hanfei1991
Copy link
Member

/merge

@zhouqiang-cl zhouqiang-cl added backport-5.0.3 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 21, 2021
@hanfei1991
Copy link
Member

/merge

@hanfei1991
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 8fa3686 into pingcap:release-5.0 Jun 21, 2021
@hanfei1991 hanfei1991 deleted the release-5.0-52e89cb8bfba branch June 21, 2021 09:15
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.2, v5.0.3 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@qw4990 qw4990 qw4990 approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees

@hanfei1991 hanfei1991

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression sig/execution SIG execution sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @xiongjiwei @hanfei1991 @qw4990 @lzmhhh123 @zhouqiang-cl