Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: check ErrRowDoesNotMatchGivenPartitionSet when inserting rows into a partition table #25484

Merged
merged 1 commit into from
Jun 16, 2021
Merged

executor: check ErrRowDoesNotMatchGivenPartitionSet when inserting rows into a partition table #25484

merged 1 commit into from
Jun 16, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 16, 2021

What problem does this PR solve?

Issue Number: close #25253

Problem Summary: executor: check ErrRowDoesNotMatchGivenPartitionSet when inserting rows into a partition table

What is changed and how it works?

executor: check ErrRowDoesNotMatchGivenPartitionSet when inserting rows into a partition table

Check List

Tests

  • Unit test

Release note

  • executor: check ErrRowDoesNotMatchGivenPartitionSet when inserting rows into a partition table

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner sig/execution SIG execution labels Jun 16, 2021
@qw4990 qw4990 requested a review from rebelice June 16, 2021 09:03
@qw4990 qw4990 requested a review from a team as a code owner June 16, 2021 09:03
@qw4990 qw4990 requested review from lzmhhh123 and removed request for a team June 16, 2021 09:03
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 16, 2021
@qw4990 qw4990 added needs-cherry-pick-release-5.1 and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2021

/run-all-tests

@qw4990 qw4990 requested a review from morgo June 16, 2021 09:04
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@qw4990: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@pingcap pingcap deleted a comment from mini-bot Jun 16, 2021
@Rustin170506
Copy link
Member

@zhuo-zhi Please approve again, the bot just had some problems. Sorry!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • zhuo-zhi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2021

/run-check_dev_2

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2021

/run-check_dev_2

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 69603f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 16, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit ed52601 into pingcap:master Jun 16, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 16, 2021
@qw4990 @ti-srebot
cherry pick pingcap#25484 to release-5.1
b463495 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25498

ti-chi-bot pushed a commit that referenced this pull request Jun 18, 2021
@ti-srebot
executor: check ErrRowDoesNotMatchGivenPartitionSet when inserting ro…
dda34ac 
…ws into a partition table (#25484) (#25498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuo-zhi zhuo-zhi zhuo-zhi approved these changes

@rebelice rebelice rebelice approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partition insert ignore not supported, causing insert to fail
6 participants
@qw4990 @ti-chi-bot @Rustin170506 @ti-srebot @rebelice @zhuo-zhi