Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix CREATE GLOBAL TEMPORARY TABLE ... LIKE creates a normal table #25644

Merged
merged 10 commits into from
Jun 24, 2021
Merged

ddl: fix CREATE GLOBAL TEMPORARY TABLE ... LIKE creates a normal table #25644

merged 10 commits into from
Jun 24, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Jun 22, 2021

What problem does this PR solve?

Issue Number: close #25613

What is changed and how it works?

Proposal: temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59
fix issue#25613
3449680 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 22, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 22, 2021
djshow832
djshow832 reviewed Jun 22, 2021
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
@Howie59
extract a func
2f6509c 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2021
djshow832
djshow832 reviewed Jun 22, 2021
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
@Howie59
modify
d1e0a76 
Signed-off-by: lihaowei <haoweili35@gmail.com>
@Howie59
Merge branch 'master' into issue-25613
85b4d2b
@Howie59
fix err
6489a9f 
Signed-off-by: lihaowei <haoweili35@gmail.com>
djshow832
djshow832 reviewed Jun 22, 2021
View reviewed changes
ddl/ddl_api.go Outdated
if err = setTemporaryType(ctx, tbInfo, s); err != nil {
return nil, errors.Trace(err)
}
if s.TemporaryKeyword == ast.TemporaryLocal {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Why leave this judgement out of setTemporaryType?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put it into the method would AppendWarning twice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateTable calls buildTableInfoWithLike and buildTableInfoWithStmt. So there are 2 ways:

  1. Call setTemporaryType only in CreateTable, which is impossible. Because setTemporaryType must be called in the middle of buildTableInfoWithStmt, unless you remove the dependence of tbInfo.TempTableType in buildTableInfoWithStmt.
  2. Call setTemporaryType both in buildTableInfoWithLike and buildTableInfoWithStmt.

@tiancaiamao
Copy link
Contributor

I meet this bug too...

@djshow832
Copy link
Contributor

djshow832 commented Jun 23, 2021 •
edited
Loading

I meet this bug too...

Did you meet the case create global temporary table like a global temporary table? @tiancaiamao

djshow832
djshow832 reviewed Jun 24, 2021
View reviewed changes
ddl/serial_test.go Outdated Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor

I meet this bug too...

Did you meet the case create global temporary table like a global temporary table? @tiancaiamao

No, I mean create a global temporary table from a normal table...

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@tiancaiamao
Copy link
Contributor

This PR does exactly what its title says: fix CREATE GLOBAL TEMPORARY TABLE ... LIKE creates a normal table

Maybe we can pay more attention to the combinations, it's a complex matrix:

from \ to normal table global temporary table local temporary table
normal table yes (done) yes (this PR) ?
global temporary table no yes (?) ?
local temporary table ? ? ?

@Howie59
Copy link
Contributor Author

Howie59 commented Jun 24, 2021

PTAL @djshow832

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 24, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 641bce1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@tiancaiamao
Copy link
Contributor

ref #25724

@ti-chi-bot ti-chi-bot merged commit 39c547f into pingcap:master Jun 24, 2021
tiancaiamao pushed a commit to tiancaiamao/tidb that referenced this pull request Jun 25, 2021
@Howie59 @tiancaiamao
ddl: fix CREATE GLOBAL TEMPORARY TABLE ... LIKE creates a normal table (
526ff6d 
pingcap#25644)
jiajunhuang pushed a commit to jiajunhuang/tidb that referenced this pull request Jun 28, 2021
@Howie59 @jiajunhuang
ddl: fix CREATE GLOBAL TEMPORARY TABLE ... LIKE creates a normal table (
e124b5b 
pingcap#25644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CREATE GLOBAL TEMPORARY TABLE ... LIKE creates a normal table
5 participants
@Howie59 @tiancaiamao @djshow832 @ti-chi-bot @zhouqiang-cl