Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Merge global temporary table into release-5.1 #25724

Merged
merged 17 commits into from
Jun 29, 2021

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jun 24, 2021

What problem does this PR solve?

This branch is maintained for a POC of a customer, it provides the global temporary table feature based on the 5.1 branch.
And it meant to keep update with the 5.1 branch, plus the global temporary table feature.

Problem Summary:

What is changed and how it works?

What's Changed:

Initially, this branch is generated by cherry pick those PRs based on the 5.1 branch:

commit 811253785c0ed3ac84904517a73a2667f70f19f3
Author: 王超 <cclcwangchao@hotmail.com>
Date:   Mon Jun 7 21:06:28 2021 +0800

    planner, executor: add stale read compatibility for temporary table (#25206)


commit d5a0d176db39bae07f4584df119e81170dade1eb
Author: 王超 <cclcwangchao@hotmail.com>
Date:   Wed Jun 9 13:18:29 2021 +0800

    executor: add history read compatibility for temporary table (#25237)

commit cbb6f4e64cb9e46f3db3d36c8c1abbd80ebd5b73
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Wed Jun 9 18:48:30 2021 +0800

    *: add global system variable `tmp_table_size` (#24827)

commit 0ed8eafa9bf269eb2c3974ce67184aa05fbabc38
Author: 王超 <cclcwangchao@hotmail.com>
Date:   Wed Jun 9 21:14:29 2021 +0800

    executor: add tablesample compatibility for temporary table (#25288)

commit 5a1606740c5225175b5b5a64bad54cc83d3ff18c
Author: Howie <haoweili35@gmail.com>
Date:   Fri Jun 11 16:50:35 2021 +0800

    ddl: add create table like check for temporary table (#25082)

commit bd11917ca096374ca1d7915d5985f49cb111be3e
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Tue Jun 15 14:08:37 2021 +0800

    bindinfo,planner: report error when creating sql binding on temporary table (#25058)

commit ed686d1963f472b813c528543fee729a629242fb
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Thu Jun 17 16:20:37 2021 +0800

    executor: fix a stupid mistake in `filterTemporaryTableKeys()` function (#25521)

commit 9f18723e6af2e1bb10fb013a75c2397a7a575e2c
Author: tiancaiamao <tiancaiamao@gmail.com>
Date:   Mon Jun 21 16:46:53 2021 +0800

    *: fix bug that write on temporary table send request to TiKV (#25535)

How it Works:

This draft issue can make us easier to know the different between this branch and 5.1.
The branch will be maintained like this:

  • Cherry-pick temporary table related bug fixes from the master branch
  • Merge 5.1 branch regularly

Until the POC is over and we finally provide a official release branch that contains the global temporary table feature.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 24, 2021
@tiancaiamao tiancaiamao changed the title [DNM]Track the difference between the 5.1 branch and the temporary table poc branch [DNM] Track the difference between the 5.1 branch and the temporary table poc branch Jun 24, 2021
@tiancaiamao tiancaiamao changed the title [DNM] Track the difference between the 5.1 branch and the temporary table poc branch *: Track the difference between the 5.1 branch and the temporary table poc branch [DNM] Jun 24, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra labels Jun 24, 2021
@tiancaiamao
Copy link
Contributor Author

/run-check_dev

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2021
@lcwangchao lcwangchao marked this pull request as ready for review June 28, 2021 09:46
@lcwangchao lcwangchao requested review from a team as code owners June 28, 2021 09:46
@lcwangchao lcwangchao requested review from qw4990 and removed request for a team June 28, 2021 09:46
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2021
errno/errname.go Outdated Show resolved Hide resolved
errors.toml Outdated Show resolved Hide resolved
tiancaiamao and others added 2 commits June 29, 2021 16:40
Co-authored-by: bb7133 <bb7133@gmail.com>
@bb7133
Copy link
Member

bb7133 commented Jun 29, 2021

/merge

@ti-chi-bot
Copy link
Member

@bb7133: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • djshow832

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 29, 2021
@bb7133
Copy link
Member

bb7133 commented Jun 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 19c722d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2021
@ti-chi-bot
Copy link
Member

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants