-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: thoroughly push down count-distinct agg in the MPP mode. (#25662) #25861
planner/core: thoroughly push down count-distinct agg in the MPP mode. (#25662) #25861
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@hanfei1991 you're already a collaborator in bot's repo. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3f09286
|
/merge |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #25662 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25861
After apply modifications, you can push your change to this PR via:
…up by columns
What problem does this PR solve?
Problem Summary:
Right now for count-distinct agg we can only execute the dedup part on TiFlash and gather all the intermediate data to get final result on TiDB. However the execution in TiDB will be the performance bottleneck so we hope to push down this part in MPP mode.
What is changed and how it works?
What's Changed:
We check the group by columns and distinct functions during
exhaustPhysicalPlans
and set the physical hint toMppScalar
indicating this is a scalar function then we will push down all the calculation. This tune only takes effect in the MPP mode.How it Works:
for a simple statement:
select count(distinct a) from t;
. The performace advance is great:before tune:
after tune
Check List
Tests
Release note