Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support drop table for label rule #26630

Merged
merged 5 commits into from
Aug 9, 2021
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 27, 2021

What problem does this PR solve?

Closes #26693. It can be reviewed after #26511 is merged.

What is changed and how it works?

Add a rule for a table, show it from PD API:

mysql> alter table t1 attributes="attr";

# curl http://127.0.0.1:2379/pd/api/v1/config/region-label/rules
[
  {
    "id": "schema/test/t1",
    "labels": [
      {
        "key": "attr",
        "value": "true"
      },
      {
        "key": "db",
        "value": "test"
      },
      {
        "key": "table",
        "value": "t1"
      }
    ],
    "rule_type": "key-range",
    "rule": {
      "start_key": "7480000000000000ff355f720000000000fa",
      "end_key": "7480000000000000ff365f720000000000fa"
    }
  }
]

After GC finish:

# curl http://127.0.0.1:2379/pd/api/v1/config/region-label/rules
[]

What's Changed:

  1. add GC logic for label rules
  2. add UpdateLabelRules to batch update/delete the rules

Check List

Tests

  • Unit test

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 27, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 27, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 30, 2021
@rleungx
Copy link
Member Author

rleungx commented Jul 30, 2021

/cc @xhebox @Yisaer

@ti-chi-bot ti-chi-bot requested review from xhebox and Yisaer July 30, 2021 10:23
@rleungx
Copy link
Member Author

rleungx commented Jul 30, 2021

/run-check_dev_2

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 5, 2021

/cc @morgo @djshow832

@ti-chi-bot ti-chi-bot requested review from djshow832 and morgo August 5, 2021 05:39
@morgo
Copy link
Contributor

morgo commented Aug 9, 2021

LGTM

@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8a8842d88538b6d49e51153e07814e9075d7ef5e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
rleungx added 4 commits August 9, 2021 12:50
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 25967c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member Author

rleungx commented Aug 9, 2021

/rebuild

@ti-chi-bot ti-chi-bot merged commit 4684a7f into pingcap:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support drop table for label rule
6 participants