Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support drop partition for label rules #26795

Merged
merged 3 commits into from
Aug 31, 2021
Merged

ddl: support drop partition for label rules #26795

merged 3 commits into from
Aug 31, 2021

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 2, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #26794.

This PR should be reviewed after #26630 is merged.

What is changed and how it works?

What's Changed:

  • Add a new function dropLabelRules
  • Modify onDropTablePartition to drop the label rule immediately

Check List

Tests

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 2, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2021
@rleungx
Copy link
Member Author

rleungx commented Aug 25, 2021

/cc @xhebox @disksing @Yisaer

@ti-chi-bot
Copy link
Member

@disksing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2021
xhebox
xhebox reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer the comment #27102 (review), the PR will be approved, but needs some followup.

ddl/partition.go Outdated
}
// delete batch rules
patch := label.NewRulePatch(nil, deleteRules)
err := infosync.UpdateLabelRules(context.TODO(), patch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just return infosync.UpdateLabelRules(context.TODO(), patch).

@rleungx
support drop partition for label rule
1b8afc0 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
address the comment
d914bf7 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 31, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d914bf7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2021
@ti-chi-bot ti-chi-bot merged commit 79d3622 into pingcap:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@disksing disksing disksing approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support drop partition for label rules
5 participants
@rleungx @ti-chi-bot @xhebox @disksing @Yisaer