executor: migrate TestBatchInsertWithOnDuplicate to testify #26712

tisonkun · 2021-07-28T14:28:04Z

What problem does this PR solve?

Issue Number: close #26160

See also commits, I already separated into three commits.

Release note

None

Signed-off-by: tison <wander4096@gmail.com>

ti-chi-bot · 2021-07-28T14:28:05Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

ichn-hu
xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: tison <wander4096@gmail.com>

tisonkun · 2021-07-29T07:26:12Z

/cc @mmyj

ti-chi-bot · 2021-07-29T07:26:13Z

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mmyj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ichn-hu · 2021-08-03T03:40:08Z

executor/main_test.go

+		goleak.IgnoreTopFunction("go.opencensus.io/stats/view.(*worker).start"),
+		goleak.IgnoreTopFunction("gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"),
+	}
+	goleak.VerifyTestMain(m, opts...)


why do we need to ignore these functions? how do we determine which function to ignore?

see also https://internals.tidb.io/t/topic/280/2 They are already ignored by testleak and when we migrate to goleak, we repeat it.

Hopefully we later fix all unreasonable leak, but we don't force it in this PR IMO.

Because all the scope consists of other tests expect TestBatchInsertWithOnDuplicate, and actually, TestBatchInsertWithOnDuplicate doesn't suffer.

Sure, thanks for the explanation.

mmyj · 2021-08-03T14:29:47Z

/merge

ti-chi-bot · 2021-08-03T14:29:49Z

This pull request has been accepted and is ready to merge.

Commit hash: 602d8dc

tiancaiamao

I guess the leak is caused by other cases.
If you run

go test TestBatchInsertWithOnDuplicate

There is no leak from our repo.

executor/main_test.go

tisonkun · 2021-08-04T02:04:20Z

I guess the leak is caused by other cases.
If you run
go test TestBatchInsertWithOnDuplicate
There is no leak from our repo.

@tiancaiamao Yes it is not caused by TestBatchInsertWithOnDuplicate. As you can see TestMain actually handle the whole package. I think it is other tests to be blamed. You may be right that it is because store not close, etc. But we don't have to resolve in this PR since they are already ignored. We can gradually fix them on the fly refactoring IMO.

xhebox · 2021-08-04T03:29:05Z

@xhebox if it is good to go, please help on tag as can-merge.

Not a committer, and I will wait for the opionion from tiancaiamao.

tiancaiamao · 2021-08-04T03:42:35Z

I'm testing this branch, using binary search to locate the leak case.

go test -run [A-N] success
go test -run [N-Z] fail ...

Maybe when it fails when including the TestT ... let me have a try

tiancaiamao · 2021-08-04T04:19:52Z

go test -run TestT -check.f Test[N-T] leak
go test -run TestT -check.f Test[N-Q] leak
go test -run TestT -check.f Test[N-O] no leak
go test -run TestT -check.f TestO no leak
go test -run TestT -check.f TestP leak

./memory_test.go:func (s *testMemoryLeak) TestPBMemoryLeak(c *C) {
./parallel_apply_test.go:func (s *testSuite) TestParallelApply(c *C) {
./executor_test.go:func (s *testSuiteP1) TestPessimisticSelectForUpdate(c *C) {
./executor_test.go:func (s *testSerialSuite) TestPointGetRepeatableRead(c *C) {
./executor_test.go:func (s *testSuiteP2) TestPointGetPreparedPlan(c *C) {
./executor_test.go:func (s *testSuiteP2) TestPointGetPreparedPlanWithCommitMode(c *C) {
./executor_test.go:func (s *testSuiteP2) TestPointUpdatePreparedPlan(c *C) {
./executor_test.go:func (s *testSuiteP2) TestPointUpdatePreparedPlanWithCommitMode(c *C) {
./executor_test.go:func (s *testSuite1) TestPartitionHashCode(c *C) {
./executor_test.go:func (s *testSuiteP1) TestPrepareLoadData(c *C) {
./executor_test.go:func (s *testSerialSuite) TestPrevStmtDesensitization(c *C) {
./executor_test.go:func (s *testSuiteP2) TestProjectionBitType(c *C) {
./seqtest/seq_executor_test.go:func (s *seqTestSuite) TestParallelHashAggClose(c *C) {
./seqtest/seq_executor_test.go:func (s *seqTestSuite) TestPrepareMaxParamCountCheck(c *C) {
./seqtest/seq_executor_test.go:func (s *seqTestSuite) TestPessimisticConflictRetryAutoID(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPrepared(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedLimitOffset(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedNullParam(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPrepareWithAggregation(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedIssue7579(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedInsert(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedUpdate(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedDelete(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPrepareDealloc(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedIssue8153(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedIssue8644(c *C) {
./seqtest/prepared_test.go:func (s *seqTestSuite) TestPreparedIssue17419(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionIndexJoin(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionUnionScanIndexJoin(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPointGetwithRangeAndListPartitionTable(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionReaderUnderApply(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionInfoDisable(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionTableWithDifferentJoin(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestParallelApply(c *C) {
./update_test.go:func (s *testSuite11) TestPessimisticUpdatePKLazyCheck(c *C) {
./batch_point_get_test.go:func (s *testBatchPointGetSuite) TestPointGetForTemporaryTable(c *C) {
./shuffle_test.go:func (s *testPartitionSuite) TestPartitionRangeSplitter(c *C) {
./infoschema_reader_test.go:func (s *testInfoschemaTableSuite) TestProfiling(c *C) {
./infoschema_reader_test.go:func (s *testInfoschemaTableSerialSuite) TestPartitionsTable(c *C) {
./prepared_test.go:func (s *testSuite1) TestPreparedNameResolver(c *C) {
./prepared_test.go:func (s *testSuite1) TestPreparedDDL(c *C) {
./prepared_test.go:func (s *testSerialSuite) TestPrepareStmtAfterIsolationReadChange(c *C) {
./prepared_test.go:func (s *testSuite12) TestPreparedStmtWithHint(c *C) {
./prepared_test.go:func (s *testSerialSuite) TestPlanCacheClusterIndex(c *C) {
./prepared_test.go:func (s *testPrepareSuite) TestPlanCacheWithDifferentVariableTypes(c *C) {
./window_test.go:func (s *testSuite7) TestPipelinedWindowFunctions(c *C) {
./window_test.go:func (s *testSuite7) TestPipelinedWindowParallelFunctions(c *C) {
./window_test.go:func (s *testSuite7) TestPipelinedSlidingWindowFunctions(c *C) {
./tiflash_test.go:func (s *tiflashTestSuite) TestPartitionTable(c *C) {
./index_lookup_join_test.go:func (s *testSuite5) TestPartitionTableIndexJoinAndIndexReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPushLimitDownIndexLookUpReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPartitionTableIndexLookUpReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPartitionTableRandomlyIndexLookUpReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPartitionTableIndexJoinIndexLookUp(c *C) {
./explainfor_test.go:func (s *testPrepareSerialSuite) TestPointGetUserVarPlanCache(c *C) {
./slow_query_test.go:func (s *testExecSerialSuite) TestParseSlowLogPanic(c *C) {
./slow_query_test.go:func (s *testExecSuite) TestParseSlowLogFile(c *C) {
./slow_query_test.go:func (s *testExecSerialSuite) TestParseSlowLogFileSerial(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGet(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetOverflow(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetDataTooLong(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetCharPK(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetAliasTableCharPK(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetVarcharPK(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetBinaryPK(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetAliasTableBinaryPK(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetByRowID(c *C) {
./point_get_test.go:func (s *testSerialSuite) TestPartitionMemCacheReadLock(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetWriteLock(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetLockExistKey(c *C) {
./point_get_test.go:func (s *testPointGetSuite) TestPointGetIssue25167(c *C) {
./index_merge_reader_test.go:func (s *testSuite1) TestPartitionTableRandomIndexMerge(c *C) {
./aggregate_test.go:func (s *testSuiteAgg) TestPR15242ShallowCopy(c *C) {
./aggregate_test.go:func (s *testSuiteAgg) TestParallelStreamAggGroupConcat(c *C) {
./write_test.go:func (s *testSuite4) TestPartitionedTableReplace(c *C) {
./write_test.go:func (s *testSuite4) TestPartitionedTableUpdate(c *C) {
./write_test.go:func (s *testSuite4) TestPartitionedTableDelete(c *C) {
./write_test.go:func (s *testSuite7) TestPessimisticDeleteYourWrites(c *C) {
./aggfuncs/func_percentile_test.go:func (s *testSuite) TestPercentile(c *C) {
./executor_required_rows_test.go:func (s *testExecSuite) TestProjectionUnparallelRequiredRows(c *C) {
./executor_required_rows_test.go:func (s *testExecSuite) TestProjectionParallelRequiredRows(c *C) {
./insert_test.go:func (s *testSuite10) TestPaddingCommonHandle(c *C) {
./insert_test.go:func (s *testSuite3) TestPartitionInsertOnDuplicate(c *C) {

tiancaiamao · 2021-08-04T04:31:03Z

go test -run TestT -check.f TestP[a-n] leak
go test -run TestT -check.f TestP[a-g] leak
go test -run TestT -check.f TestP[a-e] leak
go test -run TestT -check.f TestPa leak
go test -run TestT -check.f TestPartition leak

./executor_test.go:func (s *testSuite1) TestPartitionHashCode(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionIndexJoin(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionUnionScanIndexJoin(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionReaderUnderApply(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionInfoDisable(c *C) {
./partition_table_test.go:func (s *partitionTableSuite) TestPartitionTableWithDifferentJoin(c *C) {
./shuffle_test.go:func (s *testPartitionSuite) TestPartitionRangeSplitter(c *C) {
./infoschema_reader_test.go:func (s *testInfoschemaTableSerialSuite) TestPartitionsTable(c *C) {
./tiflash_test.go:func (s *tiflashTestSuite) TestPartitionTable(c *C) {
./index_lookup_join_test.go:func (s *testSuite5) TestPartitionTableIndexJoinAndIndexReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPartitionTableIndexLookUpReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPartitionTableRandomlyIndexLookUpReader(c *C) {
./distsql_test.go:func (s *testSuite3) TestPartitionTableIndexJoinIndexLookUp(c *C) {
./point_get_test.go:func (s *testSerialSuite) TestPartitionMemCacheReadLock(c *C) {
./index_merge_reader_test.go:func (s *testSuite1) TestPartitionTableRandomIndexMerge(c *C) {
./write_test.go:func (s *testSuite4) TestPartitionedTableReplace(c *C) {
./write_test.go:func (s *testSuite4) TestPartitionedTableUpdate(c *C) {
./write_test.go:func (s *testSuite4) TestPartitionedTableDelete(c *C) {
./insert_test.go:func (s *testSuite3) TestPartitionInsertOnDuplicate(c *C) {

go test -run TestT -check.f testSuite1.TestPart no leak
go test -run TestT -check.f partitionTableSuite.TestPart no leak
go test -run TestT -check.f testPartitionSuite.TestPart no leak
go test -run TestT -check.f testInfoschemaTableSerialSuite.TestPart no leak
go test -run TestT -check.f tiflashTestSuite.TestPart leak!!!!

This is the root cause @tisonkun

tisonkun · 2021-08-04T04:43:10Z

@tiancaiamao thanks! I think we can comment this information on #26854 and fix them on the fly? Or you think it block this PR to merge?

tiancaiamao · 2021-08-04T04:56:46Z

I've filed a PR to fix the leak I found #26881

IMO, add a whitelist of goleak.Option is not a good idea.
It's easy to add the whitelist, but very difficult to remove it.

So what's the purpose of the test case restructing? we want the code to be maintainable, the test case to be more stable ... this time it's a good chance for us to improve, but if we add the bad cases into the whitelist, nothing improved. We can't achieve anything we really wanted ...

tisonkun · 2021-08-04T05:16:45Z

I've filed a PR to fix the leak I found #26881

IMO, add a whitelist of goleak.Option is not a good idea.
It's easy to add the whitelist, but very difficult to remove it.

So what's the purpose of the test case restructing? we want the code to be maintainable, the test case to be more stable ... this time it's a good chance for us to improve, but if we add the bad cases into the whitelist, nothing improved. We can't achieve anything we really wanted ...

Agree and thank you for the PR!

tisonkun · 2021-08-04T05:22:45Z

@tiancaiamao actually I keep a same opinion with you as already posted on https://internals.tidb.io/t/topic/200/3?u=tison. My suggestion is unblocking this PR and later drop unreasonable leak ignores. You may think "later" be never and that's great you help on fixing it right now.

tisonkun · 2021-08-04T09:58:26Z

Given #26881 merged, let me try to remove the whitelist.

tisonkun · 2021-08-04T10:09:02Z

@tiancaiamao there are still leaks https://gist.github.com/tisonkun/01c6fa0778849b1ca330efb5f29e3e0b

tisonkun · 2021-08-04T10:10:21Z

If you don't like whitelist, we can avoid using goleak.verifyMain here, create another issue to add it back the debug in that PR.

Signed-off-by: tison <wander4096@gmail.com>

tisonkun · 2021-08-04T10:57:49Z

@tiancaiamao I push two commits to narrow goleak validation in the migrated functions. PTAL

tisonkun · 2021-08-04T12:19:57Z

Ummm well goleak verify stack and we can hardly run it separatedly

Signed-off-by: tison <wander4096@gmail.com>

tiancaiamao · 2021-08-04T14:12:53Z

testkit/mockstore.go

+	session.SetSchemaLease(0)
+	session.DisableStats4Test()
+	d, err := session.BootstrapSession(store)


I have a concern this will make our CI take a lot of time than before.
In the past, one test suite create one store/domain.
If after the refactor, each test case create one store/domain, the operation is heavier than before... session.BootstrapSession is not cheap.

We can solve it later, through~

OK. I'll think of reusing store/domain between tests. Maybe we come back to batch several tests in serial with testify suite.

tiancaiamao · 2021-08-04T14:15:45Z

/merge

ti-chi-bot · 2021-08-04T14:15:48Z

This pull request has been accepted and is ready to merge.

Commit hash: f70c4ae

ti-chi-bot · 2021-08-04T18:36:38Z

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

tisonkun added 3 commits July 28, 2021 19:06

executor: introduce TestMain

99e7967

Signed-off-by: tison <wander4096@gmail.com>

factor out CreateMockStore

49f6a1a

Signed-off-by: tison <wander4096@gmail.com>

executor: migrate TestBatchInsertWithOnDuplicate to testify

570a4e5

Signed-off-by: tison <wander4096@gmail.com>

tisonkun requested review from tiancaiamao and xhebox July 28, 2021 14:28

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2021

github-actions bot added the sig/execution SIG execution label Jul 28, 2021

tisonkun added 2 commits July 28, 2021 23:21

go fmt

fbe2f7e

Signed-off-by: tison <wander4096@gmail.com>

golinter

602d8dc

Signed-off-by: tison <wander4096@gmail.com>

tisonkun mentioned this pull request Jul 29, 2021

Implement testkits for server tests #26108

Closed

xhebox approved these changes Jul 30, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2021

tisonkun requested a review from ichn-hu August 2, 2021 13:17

ichn-hu reviewed Aug 3, 2021

View reviewed changes

ichn-hu approved these changes Aug 3, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021

Merge branch 'master' into issue-26160

c110a9d

tiancaiamao reviewed Aug 3, 2021

View reviewed changes

executor/main_test.go Outdated Show resolved Hide resolved

executor/main_test.go Outdated Show resolved Hide resolved

executor/main_test.go Outdated Show resolved Hide resolved

ti-chi-bot added 2 commits August 4, 2021 00:01

Merge branch 'master' into issue-26160

09407d7

Merge branch 'master' into issue-26160

166b8cc

Merge branch 'master' into issue-26160

912f1ba

tiancaiamao mentioned this pull request Aug 4, 2021

executor: fix leak of tiflashTestSuite #26881

Merged

12 tasks

Merge branch 'master' into issue-26160

96783c8

tisonkun added 2 commits August 4, 2021 18:44

goleak verify only TestBatchInsertWithOnDuplicate for now

4bdc7ee

Signed-off-by: tison <wander4096@gmail.com>

ignore functions

f6b55b2

Signed-off-by: tison <wander4096@gmail.com>

remove goleak

f70c4ae

Signed-off-by: tison <wander4096@gmail.com>

tiancaiamao reviewed Aug 4, 2021

View reviewed changes

tiancaiamao approved these changes Aug 4, 2021

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2021

ti-chi-bot added 2 commits August 4, 2021 22:15

Merge branch 'master' into issue-26160

3fae080

Merge branch 'master' into issue-26160

03ca5a3

ti-chi-bot merged commit f9652b2 into pingcap:master Aug 4, 2021

tisonkun mentioned this pull request Aug 12, 2021

server: migrate packetIO related tests to testify #27042

Merged

unconsolable mentioned this pull request Aug 17, 2021

executor/cte_test.go: migrate test-infra to testify #27103

Merged

tisonkun deleted the issue-26160 branch March 4, 2022 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: migrate TestBatchInsertWithOnDuplicate to testify #26712

executor: migrate TestBatchInsertWithOnDuplicate to testify #26712

tisonkun commented Jul 28, 2021 •

edited

Loading

ti-chi-bot commented Jul 28, 2021 •

edited

Loading

tisonkun commented Jul 29, 2021

ti-chi-bot commented Jul 29, 2021

ichn-hu Aug 3, 2021

tisonkun Aug 3, 2021

tisonkun Aug 3, 2021

tisonkun Aug 3, 2021 •

edited

Loading

ichn-hu Aug 3, 2021

mmyj commented Aug 3, 2021

ti-chi-bot commented Aug 3, 2021

tiancaiamao left a comment

tisonkun commented Aug 4, 2021

xhebox commented Aug 4, 2021

tiancaiamao commented Aug 4, 2021

tiancaiamao commented Aug 4, 2021

tiancaiamao commented Aug 4, 2021

tisonkun commented Aug 4, 2021 •

edited

Loading

tiancaiamao commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021 •

edited

Loading

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tiancaiamao Aug 4, 2021

tiancaiamao Aug 4, 2021

tisonkun Aug 5, 2021

tiancaiamao commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

executor: migrate TestBatchInsertWithOnDuplicate to testify #26712

executor: migrate TestBatchInsertWithOnDuplicate to testify #26712

Conversation

tisonkun commented Jul 28, 2021 • edited Loading

What problem does this PR solve?

Release note

ti-chi-bot commented Jul 28, 2021 • edited Loading

tisonkun commented Jul 29, 2021

ti-chi-bot commented Jul 29, 2021

ichn-hu Aug 3, 2021

Choose a reason for hiding this comment

tisonkun Aug 3, 2021

Choose a reason for hiding this comment

tisonkun Aug 3, 2021

Choose a reason for hiding this comment

tisonkun Aug 3, 2021 • edited Loading

Choose a reason for hiding this comment

ichn-hu Aug 3, 2021

Choose a reason for hiding this comment

mmyj commented Aug 3, 2021

ti-chi-bot commented Aug 3, 2021

tiancaiamao left a comment

Choose a reason for hiding this comment

tisonkun commented Aug 4, 2021

xhebox commented Aug 4, 2021

tiancaiamao commented Aug 4, 2021

tiancaiamao commented Aug 4, 2021

tiancaiamao commented Aug 4, 2021

tisonkun commented Aug 4, 2021 • edited Loading

tiancaiamao commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021 • edited Loading

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tisonkun commented Aug 4, 2021

tiancaiamao Aug 4, 2021

Choose a reason for hiding this comment

tiancaiamao Aug 4, 2021

Choose a reason for hiding this comment

tisonkun Aug 5, 2021

Choose a reason for hiding this comment

tiancaiamao commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

ti-chi-bot commented Aug 4, 2021

tisonkun commented Jul 28, 2021 •

edited

Loading

ti-chi-bot commented Jul 28, 2021 •

edited

Loading

tisonkun Aug 3, 2021 •

edited

Loading

tisonkun commented Aug 4, 2021 •

edited

Loading

tisonkun commented Aug 4, 2021 •

edited

Loading