Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: migrate test-infra to testify for expression/collation_test.go (#28849) #28965

Merged
merged 6 commits into from
Oct 27, 2021
Merged

expression: migrate test-infra to testify for expression/collation_test.go (#28849) #28965

merged 6 commits into from
Oct 27, 2021

Conversation

agneum
Copy link
Contributor

@agneum agneum commented Oct 19, 2021

What problem does this PR solve?

Issue Number: close #28849

Problem Summary:

What is changed and how it works?

What's Changed:

  • Migrate test-infra to testify for expression/collation_test.go

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2021
@agneum
Copy link
Contributor Author

agneum commented Oct 19, 2021

/cc @Reviewer

@ti-chi-bot
Copy link
Member

@agneum: GitHub didn't allow me to request PR reviews from the following users: reviewer.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Reviewer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agneum
Copy link
Contributor Author

agneum commented Oct 20, 2021

/cc @tisonkun

@agneum
Copy link
Contributor Author

agneum commented Oct 25, 2021

@tisonkun Could you please review the PR?

@tisonkun
Copy link
Contributor

almost ditto comment as in #28895 , please do a self-review round.

@agneum
Copy link
Contributor Author

agneum commented Oct 26, 2021 •
edited
Loading

almost ditto comment as in #28895 , please do a self-review round.

@tisonkun Thanks, I've fixed this PR too

tisonkun
tisonkun approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your updates!

/cc @wjhuang2016

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2021
@tisonkun
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2021
@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f978085

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2021
@ti-chi-bot
Copy link
Member

@agneum: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b81296f into pingcap:master Oct 27, 2021
xiongjiwei
xiongjiwei reviewed Nov 1, 2021
View reviewed changes
expression/collation_test.go
)

var _ = SerialSuites(&testCollationSuites{})
func TestCompareString(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can not make it parallel, see #29125 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei left review comments

@tisonkun tisonkun tisonkun approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for expression/collation_test.go
5 participants
@agneum @ti-chi-bot @tisonkun @wjhuang2016 @xiongjiwei