Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: migrate builtin tests #29125

Merged
merged 21 commits into from
Oct 27, 2021
Merged

expression: migrate builtin tests #29125

merged 21 commits into from
Oct 27, 2021

Conversation

tisonkun
Copy link
Contributor

This refers to #26855 .

Signed-off-by: tison wander4096@gmail.com

Release note

None

/cc @xhebox @mmyj

@tisonkun
expression: migrate builtin tests [a-e]
b19ee43 
This refers to pingcap#26855 .

Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mmyj
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 26, 2021
@tisonkun
expression: migrate builtin_info_test.go
a7f4b8f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_json_test.go
de96538 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun changed the title expression: migrate builtin tests [a-e] expression: migrate builtin tests [a-j] Oct 26, 2021
@tisonkun
expression: migrate builtin_like_test.go
18a4f07 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_math_test.go
bce85f0 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_miscellaneous_test.go
6a8df8c 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_miscellaneous_vec_test.go
80e36e6 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun changed the title expression: migrate builtin tests [a-j] expression: migrate builtin tests [a-m] Oct 26, 2021
@tisonkun
expression: migrate builtin_op_test.go
cd35d2f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_op_vec_test.go
488af3d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_other_test.go
af3d134 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_other_vec_test.go
be2b8a8 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_regexp_vec_const_test.go
a1ebd91 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_string_test.go
a8fbcc3 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun changed the title expression: migrate builtin tests [a-m] expression: migrate builtin tests [a-s] Oct 27, 2021
@tisonkun
expression: migrate builtin_test.go
51b0882 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as draft October 27, 2021 01:13
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
@tisonkun
Copy link
Contributor Author

wait a minute, I think I can finish all builtin today.

@tisonkun
expression: migrate builtin_time_test.go
6c4eae8 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_time_vec_test.go
2f9ff9d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
expression: migrate builtin_vectorized_test.go
ad6ea85 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review October 27, 2021 01:39
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
@tisonkun
Copy link
Contributor Author

ready for review

/cc @djshow832

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 27, 2021 •
edited
Loading

You can review in commits or in files.

@tisonkun tisonkun changed the title expression: migrate builtin tests [a-s] expression: migrate builtin tests Oct 27, 2021
xhebox
xhebox approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot, LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 27, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2021
mmyj
mmyj approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2021
@mmyj
Copy link
Member

mmyj commented Oct 27, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0579fa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2021
@ti-chi-bot ti-chi-bot merged commit b7ed87d into pingcap:master Oct 27, 2021
@tisonkun tisonkun deleted the expression-testify branch October 27, 2021 15:56
@tisonkun
Copy link
Contributor Author

credit to @feitian124 's https://github.com/feitian124/migrate-helper

It helps a lot.

xiongjiwei
xiongjiwei reviewed Nov 1, 2021
View reviewed changes
expression/builtin_other_test.go
}
}

func (s *testEvaluatorSuite) TestInFunc(c *C) {
func TestInFunc(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot make it parallel because of there is collate.SetNewCollationEnabledForTest(true) at L134

Copy link
Contributor

@feitian124 feitian124 Nov 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i created a issue #29319 to track this and hope correct all of this kind issues in one pr. could you please comment there to provide more detail about why call that functin the tests should run in serial?

@xiongjiwei xiongjiwei mentioned this pull request Nov 1, 2021
Merged
1 task
xiongjiwei referenced this pull request Nov 1, 2021
@sankalp-r
planner/core: migrate test-infra to testify for planner/core/plan_to_…
a9a3b3c 
…pb_test.go (#28452)
xiongjiwei referenced this pull request Nov 1, 2021
@feitian124
statistics: migrate test-infra to testify for selectivity_test.go (#2…
3762608 
…8796)
This was referenced Nov 1, 2021
Merged
Merged
Merged
xiongjiwei
xiongjiwei reviewed Nov 1, 2021
View reviewed changes
expression/builtin_string_test.go
}
}
}

func (s *testEvaluatorSerialSuites) TestCIWeightString(c *C) {
func TestCIWeightString(t *testing.T) {
t.Parallel()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@feitian124 feitian124 mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei left review comments

@feitian124 feitian124 feitian124 left review comments

@mmyj mmyj mmyj approved these changes

@xhebox xhebox xhebox approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tisonkun @ti-chi-bot @mmyj @feitian124 @xhebox @xiongjiwei