-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove direct placement option #31423
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ef45800bf2cd2fb2ec6bc28b6f4c93a5b506e546 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just some minor nitpicking (including fixing older issues).
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no other concerns for now, but let us wait for eason.
LGTM |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 114b20e
|
@morgo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #18030
Problem Summary:
This updates the proposal for Placement Rules in SQL to remove direct placement, which was requested by the product mangement team. When removing direct placement, there are other changes that need to be made for the design to make sense (i.e. infoschema.placement_rules doesn't make sense. So it is renamed to infoschema.placement_policies).
This also updates the design doc for #31093 by @lcwangchao
Sub-tasks required to adjust the design will be added to #18030
What is changed and how it works?
Direct Placement options are no longer supported by Placement rules in SQL. Please use a placement policy instead.
Check List
Tests
Side effects
Documentation
Release note