Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove direct placement option #31423

Merged
merged 9 commits into from
Jan 11, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jan 6, 2022

What problem does this PR solve?

Issue Number: ref #18030

Problem Summary:

This updates the proposal for Placement Rules in SQL to remove direct placement, which was requested by the product mangement team. When removing direct placement, there are other changes that need to be made for the design to make sense (i.e. infoschema.placement_rules doesn't make sense. So it is renamed to infoschema.placement_policies).

This also updates the design doc for #31093 by @lcwangchao

Sub-tasks required to adjust the design will be added to #18030

What is changed and how it works?

Direct Placement options are no longer supported by Placement rules in SQL. Please use a placement policy instead.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility (experimental feature)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Direct Placement options are no longer supported by Placement rules in SQL. Please use a placement policy instead.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • mjonss
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 6, 2022
@morgo morgo requested review from lcwangchao and xhebox January 6, 2022 21:06
@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just some minor nitpicking (including fixing older issues).

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2022
morgo and others added 4 commits January 9, 2022 18:47
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@xhebox xhebox added the require-LGT3 Indicates that the PR requires three LGTM. label Jan 11, 2022
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other concerns for now, but let us wait for eason.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2022
@easonn7
Copy link

easonn7 commented Jan 11, 2022

LGTM

@morgo morgo removed the require-LGT3 Indicates that the PR requires three LGTM. label Jan 11, 2022
@morgo
Copy link
Contributor Author

morgo commented Jan 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 114b20e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2022
@ti-chi-bot
Copy link
Member

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 79171be into pingcap:master Jan 11, 2022
@morgo morgo deleted the remove-direct-placement branch January 12, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants