Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser, planner, executor: remove non-mpp broadcast Join #31459

Merged
merged 35 commits into from
Mar 10, 2022
Merged

parser, planner, executor: remove non-mpp broadcast Join #31459

merged 35 commits into from
Mar 10, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31465

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

deprecate tidb_opt_broadcast_join

@SeaRise SeaRise requested a review from a team as a code owner January 7, 2022 11:03
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@SeaRise SeaRise mentioned this pull request Jan 7, 2022
Merged
12 tasks
@SeaRise SeaRise changed the title [DNM] Remove non-mpp broadcast Join planner: Remove non-mpp broadcast Join Jan 7, 2022
@SeaRise SeaRise changed the title planner: Remove non-mpp broadcast Join planner: remove non-mpp broadcast Join Jan 7, 2022
@morgo morgo self-requested a review January 8, 2022 06:20
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 8, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 13, 2022

/run-unit-test

@ti-chi-bot
Copy link
Member

@hsyuan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 10, 2022

/build

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 10, 2022

/run-unit-test

chrysan
chrysan approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@chrysan chrysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@chrysan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

windtalker
windtalker approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3b6e64c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 10, 2022

@morgo PTAL

morgo
morgo approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo
Copy link
Contributor

morgo commented Mar 10, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 469bc71 into pingcap:master Mar 10, 2022
@SeaRise SeaRise deleted the remove_old_brocast_join branch March 11, 2022 02:08
@SeaRise SeaRise mentioned this pull request Mar 23, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@hsyuan hsyuan hsyuan approved these changes

@chrysan chrysan chrysan approved these changes

@windtalker windtalker windtalker approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove non-mpp broadcast Join
8 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @morgo @chrysan @hsyuan @hanfei1991