Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remote query #3827

Merged
merged 3 commits into from
Jan 10, 2022
Merged

remove remote query #3827

merged 3 commits into from
Jan 10, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 7, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

ref:
pingcap/tidb#31459
pingcap/tipb#255

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 7, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jan 7, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/889/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49737 out of 113921)
branches: 6.4% (80894 out of 1261156)

@SeaRise SeaRise changed the title [DNM] remove remote query remove remote query Jan 7, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2022
@fuzhe1989
Copy link
Contributor

/run-all-tests

@dragonly dragonly mentioned this pull request Jan 10, 2022
12 tasks
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/909/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49737 out of 113923)
branches: 6.4% (80905 out of 1261162)

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 10, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e2d6f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/912/cobertura/
(Coverage detail url is limited office network access)

lines: 43.9% (49992 out of 113991)
branches: 6.4% (81356 out of 1262001)

@ti-chi-bot ti-chi-bot merged commit 41fe142 into pingcap:master Jan 10, 2022
@SeaRise SeaRise deleted the remove_remote_query branch February 14, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants