Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix panic during update stmt #36230

Merged
merged 47 commits into from
Jul 25, 2022
Merged

executor: fix panic during update stmt #36230

merged 47 commits into from
Jul 25, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Jul 15, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32311

Problem Summary:

CheckUpdateList may cause panic by out of range due to schema changed.

What is changed and how it works?

This request fixed it

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer
fix and test
5b0d1a2 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
revise test
dcec178 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jul 15, 2022
@Yisaer Yisaer marked this pull request as ready for review July 20, 2022 07:00
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@Yisaer
address the comment
344fca1 
Signed-off-by: yisaer <disxiaofei@163.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cf4b60afab5fc6f980b397061800bf2c1ceca053

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@Yisaer
revise test
040b3f4 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2022
@Yisaer
revise test
6b31c20 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
revise test
b1370cd 
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Merge branch 'master' into fix_32311
e424de1
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Jul 25, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@Yisaer
fix test
064670b 
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Jul 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 064670b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@ti-chi-bot ti-chi-bot merged commit c768881 into pingcap:master Jul 25, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 25, 2022
@Yisaer @ti-srebot
cherry pick pingcap#36230 to release-5.4
109c8c4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 25, 2022
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36521

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 25, 2022
@Yisaer @ti-srebot
cherry pick pingcap#36230 to release-6.0
6560c9c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 25, 2022
Closed
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36526

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 25, 2022
@Yisaer @ti-srebot
cherry pick pingcap#36230 to release-6.1
306b652 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 25, 2022
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36528

@sre-bot
Copy link
Contributor

sre-bot commented Jul 25, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 11 tests passed 49 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 43 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 15 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 4 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 25 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 25, 2022
@Yisaer @ti-srebot
cherry pick pingcap#36230 to release-6.2
dc554a5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 25, 2022
Merged
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36529

ti-chi-bot pushed a commit that referenced this pull request Jul 28, 2022
@ti-srebot
executor: fix panic during update stmt (#36230) (#36529)
127c542 
close #32311
ti-chi-bot pushed a commit that referenced this pull request Aug 2, 2022
@ti-srebot
executor: fix panic during update stmt (#36230) (#36528)
99dfc62 
close #32311
ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
executor: fix panic during update stmt (#36230) (#36521)
965bb79 
close #32311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb connection running loop panic while add and drop column
6 participants
@Yisaer @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @xuyifangreeneyes