Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: prevent returning zero schema version for alter sequence #36277

Merged
merged 28 commits into from
Jul 21, 2022
Merged

ddl: prevent returning zero schema version for alter sequence #36277

merged 28 commits into from
Jul 21, 2022

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jul 18, 2022 •
edited
Loading

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #36276

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [] Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

ddl: fix alter sequence will generate schemaVer=0 when alter options are the same as the old

@AilinKid
fix alter sequence will generate schemaVer=0 when alter options are s…
0f416ff 
…ame as the old.

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@AilinKid
make fmt
60b7b5b 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3ce9b317b568a303c9d7ccade0f1957c6b2cdd29

@tangenta tangenta changed the title ddl: fix alter sequence will generate schemaVer=0 when alter options are same as the old. ddl: prevent returning zero schema version for alter sequence Jul 18, 2022
AilinKid added 2 commits July 18, 2022 19:54
@AilinKid
address comment
0e4a255 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
address comment
3448a79 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2022
@AilinKid
make fmt
7bc387f 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 42ec4c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@AilinKid
Copy link
Contributor Author

/run-check-issue-triage-complete

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-5.0
3045b48 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #36410

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-5.1
c544d6a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36412

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-5.2
b94b314 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36413

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-5.3
c2cf895 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36414

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-5.4
de1d1ce 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36416

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-6.0
3236e93 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Closed
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36417

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 21, 2022
@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-6.1
6152822 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36418

@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 failed

@niubell
Copy link
Contributor

niubell commented Jul 25, 2022

/cherry-pick release-6.2

ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
ddl: prevent returning zero schema version for alter sequence (#36277) (
c9d8794 
#36418)

close #36276
ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
ddl: prevent returning zero schema version for alter sequence (#36277) (
f5c25d3 
#36412)

close #36276
ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
ddl: prevent returning zero schema version for alter sequence (#36277) (
bfdc8c3 
#36413)

close #36276
ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
ddl: prevent returning zero schema version for alter sequence (#36277) (
f5a0bbe 
#36410)

close #36276
ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
ddl: prevent returning zero schema version for alter sequence (#36277) (
a273480 
#36414)

close #36276
ti-chi-bot pushed a commit that referenced this pull request Aug 9, 2022
@ti-srebot
ddl: prevent returning zero schema version for alter sequence (#36277) (
3dc3508 
#36416)

close #36276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nop ALTER SEQUENCE crashed Binlog Drainer due to SchemaVersion=0
8 participants
@AilinKid @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @niubell @xhebox @Defined2014