Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: prevent returning zero schema version for alter sequence (#36277) #36414

Merged
merged 3 commits into from
Aug 9, 2022
Merged

ddl: prevent returning zero schema version for alter sequence (#36277) #36414

merged 3 commits into from
Aug 9, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 21, 2022 •
edited
Loading

cherry-pick #36277 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36414

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36414:release-5.3-1bc13cd18f85

Signed-off-by: AilinKid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #36276

Problem Summary:

What is changed and how it works?

Check List

Tests

  • [] Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

ddl: fix alter sequence will generate schemaVer=0 when alter options are the same as the old

@AilinKid @ti-srebot
cherry pick pingcap#36277 to release-5.3
c2cf895 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 21, 2022
@ti-srebot ti-srebot mentioned this pull request Jul 21, 2022
Merged
11 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Jul 21, 2022
@ti-srebot ti-srebot requested review from Defined2014 and xhebox July 21, 2022 07:20
@ti-srebot ti-srebot added this to the v5.3.1 milestone Jul 21, 2022
@ti-srebot
Copy link
Contributor Author

@AilinKid you're already a collaborator in bot's repo.

@xhebox
*: fix CI
90f39a6 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 9, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 9, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90f39a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 9, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a6eda059fa16c063d55d3af883d6320653c803dd

@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2022

/run-unit-test

1 similar comment
@xhebox
Copy link
Contributor

xhebox commented Aug 9, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit a273480 into pingcap:release-5.3 Aug 9, 2022
@xhebox xhebox deleted the release-5.3-1bc13cd18f85 branch August 9, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

@AilinKid AilinKid

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @xhebox @sre-bot @Defined2014 @VelocityLight @AilinKid