-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: remove the checkpoint after removal #36452
log-backup: remove the checkpoint after removal #36452
Conversation
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Yu Juncen <yujuncen@pingcap.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9c334568cb9f6c0d878b86705f910edde3bcaf8c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 32163d1
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.2 in PR #36508 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: Yu Juncen yujuncen@pingcap.com
What problem does this PR solve?
Issue Number: close #36423
Problem Summary:
When we removed the task, we won't remove the global checkpoint and the metric, which is misleading.
What is changed and how it works?
Remove the global checkpoint and the metric when we have watched the task removed.
NOTE: for now, all TiDB instances would listen to the task keys, we may do unnecessary works.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.