-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support ACCOUNT (UN)LOCK when creating/altering user #37052
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7333d41acf1bc4c4a9a0cb08d1e124e79f3972e1 |
0e5cbec
to
dcafd3b
Compare
/run-mysql-test tidb-test=pr/1923 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you can split the PR for such kind.
A lot change is related to the Auth()
interface which used to return boolean and now returns error...
The code change for ACCOUNT LOCK itself is not much.
/run-mysql-test tidb-test=pr/1923 |
1 similar comment
/run-mysql-test tidb-test=pr/1923 |
/run-mysql-test tidb-test=pr/1923 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a6115df
|
/run-mysql-test tidb-test=pr/1923 |
/unhold |
/run-mysql-test tidb-test=pr/1923 |
/run-mysql-test tidb-test=pr/1923 |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
…verage * upstream/master: (109 commits) *: rename TemporaryTableAttachedInfoSchema (pingcap#37408) *: enable noloopclosure (pingcap#37153) executor: add JSON opaque value condition to everywhere (pingcap#37390) *: refine mock session manager (pingcap#37400) lightning: check counter value to make code more robust (pingcap#37380) *: use go 1.19 (pingcap#36223) br: restore tiflash replica count after PiTR (pingcap#37181) testkit,executor: add MustQueryWitnContext API and fix unstable test TestCoprocessorPriority (pingcap#37382) executor: add conversion to opaque value for json_objectagg and json_arrayagg (pingcap#37337) expression: quote json path if necessarily (pingcap#37375) *: support ACCOUNT (UN)LOCK when creating/altering user (pingcap#37052) log-backup: support the ddl(exchange partition) when PiTR (pingcap#37050) *: change `integration.BeforeTest` to `integration.BeforeTestExternal` to avoid skip tests (pingcap#37341) executor: fix unstable TestGlobalMemoryTrackerOnCleanUp (pingcap#37372) util/ranger: avoid building ranges twice in detachCNFCondAndBuildRangeForIndex (pingcap#37177) statistics: track used stats status during query (pingcap#37101) *: fix data race in `TestTiFlashGroupIndexWhenStartup` (pingcap#37371) lightning: fix dpanic log when init session vars (pingcap#37301) executor: let plan replayer record table tiflash replica (pingcap#37336) types: fix a bug in casting str2str when `union` (pingcap#37242) ...
What problem does this PR solve?
Issue Number: close #37051 close #35961
Problem Summary:
ACCOUNT (UN)LOCK has not been implemented.
What is changed and how it works?
Lock/Unlock a user/role when creating/altering user.
Check List
Tests
Side effects
Documentation
Manual Test
root
to connect to tidb-server-1 and create a useruser1
, andGRANT ALL on test.* to role1
user1
alter user user1 account lock
in tidb-server-1user1
can not connect again to tidb-server-2 after it 'exit' the connectionalter user user1 account unlock
in tidb-server-1user1
can connect again to tidb-server-2Release note
Please refer to Release Notes Language Style Guide to write a quality release note.