-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add conversion to opaque value for json_objectagg and json_arrayagg #37337
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
34e6337
to
b1c4f62
Compare
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f93c3fa75903e7fed39e0e757b95487ccfdb78b8 |
9dac3a9
to
25a7580
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
PTAL @xiongjiwei |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9f1ed95
|
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
…verage * upstream/master: (109 commits) *: rename TemporaryTableAttachedInfoSchema (pingcap#37408) *: enable noloopclosure (pingcap#37153) executor: add JSON opaque value condition to everywhere (pingcap#37390) *: refine mock session manager (pingcap#37400) lightning: check counter value to make code more robust (pingcap#37380) *: use go 1.19 (pingcap#36223) br: restore tiflash replica count after PiTR (pingcap#37181) testkit,executor: add MustQueryWitnContext API and fix unstable test TestCoprocessorPriority (pingcap#37382) executor: add conversion to opaque value for json_objectagg and json_arrayagg (pingcap#37337) expression: quote json path if necessarily (pingcap#37375) *: support ACCOUNT (UN)LOCK when creating/altering user (pingcap#37052) log-backup: support the ddl(exchange partition) when PiTR (pingcap#37050) *: change `integration.BeforeTest` to `integration.BeforeTestExternal` to avoid skip tests (pingcap#37341) executor: fix unstable TestGlobalMemoryTrackerOnCleanUp (pingcap#37372) util/ranger: avoid building ranges twice in detachCNFCondAndBuildRangeForIndex (pingcap#37177) statistics: track used stats status during query (pingcap#37101) *: fix data race in `TestTiFlashGroupIndexWhenStartup` (pingcap#37371) lightning: fix dpanic log when init session vars (pingcap#37301) executor: let plan replayer record table tiflash replica (pingcap#37336) types: fix a bug in casting str2str when `union` (pingcap#37242) ...
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #25053
Problem Summary:
The behavior of
json_objectagg
andjson_arrayagg
are different with MySQL, about the binary opaque value.What is changed and how it works?
Add a condition for the binary values, and convert them to the JSON Opaque. It needs to notice that:
\t
,\n
). The MySQL also has the same behavior, though JSON path cannot contain control character.Check List
Tests
Release note