Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add conversion to opaque value for json_objectagg and json_arrayagg #37337

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

YangKeao
Copy link
Member

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #25053

Problem Summary:

The behavior of json_objectagg and json_arrayagg are different with MySQL, about the binary opaque value.

What is changed and how it works?

Add a condition for the binary values, and convert them to the JSON Opaque. It needs to notice that:

  1. The value cannot be directly casted into JSON. The cast json behavior will try to cast a string to json, which is not expected.
  2. The key could contain control character (e.g. \t, \n). The MySQL also has the same behavior, though JSON path cannot contain control character.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
drop table if exists test;
create table test (col_2 int, col_3 varbinary(163));
insert into test values (1,'o');
select json_objectagg( col_2, col_3 ) from test;

drop table if exists test;
create table test (col_2 int, col_3 binary(163));
insert into test values (1,'o');
select json_objectagg( col_2, col_3 ) from test;

drop table if exists test;
create table test (col_2 int, col_3 blob);
insert into test values (1,'o');
select json_objectagg( col_2, col_3 ) from test;

select json_objectagg( 'a', b'1010111' ) from test;

Release note

Fix the issue that the json_objectagg and json_arrayagg is not compatible with MySQL on binary value.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2022
@YangKeao YangKeao force-pushed the fix-25053 branch 2 times, most recently from 34e6337 to b1c4f62 Compare August 25, 2022 04:49
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 25, 2022

@YangKeao YangKeao force-pushed the fix-25053 branch 2 times, most recently from 9dac3a9 to 25a7580 Compare August 25, 2022 06:34
@YangKeao YangKeao requested a review from xhebox August 25, 2022 06:53
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2022
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

PTAL @xiongjiwei

@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9f1ed95

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2022
@ti-chi-bot ti-chi-bot merged commit 4c8c918 into pingcap:master Aug 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 25, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 16 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 20 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 6 min 18 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 48 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 40 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 36 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Aug 27, 2022
…verage

* upstream/master: (109 commits)
  *: rename TemporaryTableAttachedInfoSchema (pingcap#37408)
  *: enable noloopclosure (pingcap#37153)
  executor: add JSON opaque value condition to everywhere (pingcap#37390)
  *: refine mock session manager (pingcap#37400)
  lightning: check counter value to make code more robust (pingcap#37380)
  *: use go 1.19 (pingcap#36223)
  br: restore tiflash replica count after PiTR (pingcap#37181)
  testkit,executor: add MustQueryWitnContext API and fix unstable test TestCoprocessorPriority (pingcap#37382)
  executor: add conversion to opaque value for json_objectagg and json_arrayagg (pingcap#37337)
  expression: quote json path if necessarily (pingcap#37375)
  *: support ACCOUNT (UN)LOCK when creating/altering user (pingcap#37052)
  log-backup: support the ddl(exchange partition) when PiTR  (pingcap#37050)
  *: change `integration.BeforeTest` to `integration.BeforeTestExternal` to avoid skip tests (pingcap#37341)
  executor: fix unstable TestGlobalMemoryTrackerOnCleanUp (pingcap#37372)
  util/ranger: avoid building ranges twice in detachCNFCondAndBuildRangeForIndex (pingcap#37177)
  statistics: track used stats status during query (pingcap#37101)
  *: fix data race in `TestTiFlashGroupIndexWhenStartup` (pingcap#37371)
  lightning: fix dpanic log when init session vars (pingcap#37301)
  executor: let plan replayer record table tiflash replica (pingcap#37336)
  types: fix a bug in casting str2str when `union` (pingcap#37242)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json_objectagg() is not compatible with MySQL on varbinary type
5 participants