Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Remove partitioning #42475

Closed
wants to merge 8 commits into from
Closed

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Mar 22, 2023

What problem does this PR solve?

Issue Number: close #42616

Problem Summary:
Remove partitioning works by first reorganize all partitions to a single partition, then make that partition to the non-partitioned table.
Currently working for RANGE [COLUMNS], HASH and KEY partitioning. LIST [COLUMNS] is depending on #41537 to be merged.

Note
This will probably also needs support from TiFlash and TiCDC.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Added support for REMOVE PARTITIONING, to make a partitioned table non-partitioned.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 22, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Mar 22, 2023

/test all

@ti-chi-bot
Copy link
Member

@mjonss: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-linked-issue labels Mar 26, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Mar 29, 2023

Will need #41537 for supporting LIST partitioning (so one can REORGANIZE PARTITION to/from a single partition) and #42476 for supporting HASH/KEY partitioning.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2023
@mjonss mjonss mentioned this pull request Mar 31, 2023
5 tasks
@mjonss
Copy link
Contributor Author

mjonss commented Apr 4, 2023

/test all

@mjonss
Copy link
Contributor Author

mjonss commented Apr 5, 2023

/test all

@mjonss
Copy link
Contributor Author

mjonss commented Apr 5, 2023

/retest

1 similar comment
@mjonss
Copy link
Contributor Author

mjonss commented Apr 5, 2023

/retest

@mjonss mjonss changed the title ddl: Remove partitioning for RANGE [COLUMNS] ddl: Remove partitioning Apr 6, 2023
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 6, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Apr 6, 2023

/test all

@mjonss
Copy link
Contributor Author

mjonss commented Apr 6, 2023

/retest

@ti-chi-bot
Copy link
Member

@mjonss: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test f29cecd link true /test unit-test
idc-jenkins-ci-tidb/check_dev f29cecd link true /test check-dev
idc-jenkins-ci-tidb/build f29cecd link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link
Member

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2023
@mjonss
Copy link
Contributor Author

mjonss commented May 3, 2023

Replaced by #42907

@mjonss mjonss closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ALTER TABLE t REMOVE PARTITIONING
2 participants