sql: implement `SHOW BR JOBS <n:int>` and `CANCEL BR JOB <n:int>` #43074

YuJuncen · 2023-04-14T10:14:20Z

What problem does this PR solve?

Issue Number: close #43072 close

Problem Summary:
This PR implemented two new SQLs.

What is changed and how it works?

SHOW BR JOB QUERY <n:int> will display the origin SQL of the backup job. ~~(WARNING: the secret keys may not be redacted. So it requires BACKUP_ADMIN or SUPER role to be executed.)~~
CANCEL BR JOB <n:int> will cancel a running BR job. This just trivially cancel the context of the BR CLI for now.
This PR also exported the ID row of the backups to the result of SHOW BACKUPS and SHOW RESTORES, so you can reference it at the former SQLs.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Added support for `SHOW BR JOBS <n:int>` and `CANCEL BR JOB <n:int>`.

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot · 2023-04-14T10:14:22Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

BornChanger
Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-04-17T05:31:24Z

/retest-required

Signed-off-by: hillium <yujuncen@pingcap.com>

planner/core/planbuilder.go

Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>

BornChanger · 2023-04-26T10:50:00Z

errno/errcode.go

@@ -1063,6 +1063,7 @@ const (
 	ErrLoadDataInvalidOperation            = 8171
 	ErrLoadDataLocalUnsupportedOption      = 8172
 	ErrLoadDataPreCheckFailed              = 8173
+  ErrBRJobNotFound                       = 8174


BornChanger · 2023-04-26T10:51:42Z

executor/brie.go

@@ -354,6 +398,67 @@ func (b *executorBuilder) buildBRIE(s *ast.BRIEStmt, schema *expression.Schema)
 	return e
 }

+// oneshotExecutor warps a executor, making its `Next` would only be called once.


Suggested change

// oneshotExecutor warps a executor, making its `Next` would only be called once.

// oneshotExecutor wraps a executor, making its `Next` would only be called once.

BornChanger

Others lgtm

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-05-05T02:50:09Z

/retest-required

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-05-05T05:05:49Z

/retest-required

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-05-05T06:38:42Z

/retest-required

YuJuncen · 2023-05-05T06:51:17Z

/merge

ti-chi-bot · 2023-05-05T06:51:20Z

This pull request has been accepted and is ready to merge.

Commit hash: 166f68f

YuJuncen · 2023-05-05T07:04:08Z

/retest-required

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-05-05T09:12:42Z

/retest-required

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen · 2023-05-05T10:41:07Z

/merge

ti-chi-bot · 2023-05-05T10:41:11Z

This pull request has been accepted and is ready to merge.

Commit hash: 09e57e9

YuJuncen · 2023-05-06T10:25:14Z

Oops... This PR mistakenly brings #43562 to master. I think it is moral to check what branch we are in before committing. 😢

YuJuncen added 2 commits April 14, 2023 18:05

basic implementation

aca389c

Signed-off-by: hillium <yujuncen@pingcap.com>

make format && make bazel_prepare

0a7fdc3

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 14, 2023

make clippy happy

1c5bc85

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot removed the do-not-merge/needs-triage-completed label Apr 17, 2023

redact the access key (along with endpoints, consistency?)

32125ab

Signed-off-by: hillium <yujuncen@pingcap.com>

fix typo

7448ab6

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen requested review from 3pointer, Leavrth and BornChanger April 18, 2023 07:40

YuJuncen added 3 commits April 18, 2023 16:34

make err

66957a6

Signed-off-by: hillium <yujuncen@pingcap.com>

make a detailed license

e6351bc

Signed-off-by: hillium <yujuncen@pingcap.com>

remove thrilling spaces

9db27b5

Signed-off-by: hillium <yujuncen@pingcap.com>

Leavrth approved these changes Apr 18, 2023

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023

YuJuncen and others added 2 commits April 18, 2023 21:28

fix tests

2cb9058

Signed-off-by: hillium <yujuncen@pingcap.com>

Update planner/core/planbuilder.go

084ce64

Co-authored-by: Jianjun Liao <36503113+Leavrth@users.noreply.github.com>

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2023

Merge branch 'master' into show-backup-query-2

bb1ab11

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2023

BornChanger reviewed Apr 26, 2023

View reviewed changes

address comments

af8d4de

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen requested a review from BornChanger April 27, 2023 06:43

ti-chi-bot bot deleted a comment from ti-chi-bot Apr 27, 2023

BornChanger approved these changes May 5, 2023

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2023

YuJuncen added 3 commits May 5, 2023 11:49

try fix tests

d01b260

Signed-off-by: hillium <yujuncen@pingcap.com>

make fmt

f7f2eb9

Signed-off-by: hillium <yujuncen@pingcap.com>

make bazel_prepare

eaeb7b9

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen added 3 commits May 5, 2023 13:15

try fix race

234b24e

Signed-off-by: hillium <yujuncen@pingcap.com>

fix race

47c4cf0

Signed-off-by: hillium <yujuncen@pingcap.com>

make fmt

166f68f

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2023

implementated basic pause-gc

3da80d7

Signed-off-by: hillium <yujuncen@pingcap.com>

YuJuncen added 2 commits May 5, 2023 17:39

make clippy happy

2dc141d

Signed-off-by: hillium <yujuncen@pingcap.com>

fix test

09e57e9

Signed-off-by: hillium <yujuncen@pingcap.com>

ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 5, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2023

ti-chi-bot bot merged commit 6488c35 into pingcap:master May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sql: implement `SHOW BR JOBS <n:int>` and `CANCEL BR JOB <n:int>` #43074

sql: implement `SHOW BR JOBS <n:int>` and `CANCEL BR JOB <n:int>` #43074

YuJuncen commented Apr 14, 2023 •

edited

Loading

ti-chi-bot commented Apr 14, 2023 •

edited by ti-chi-bot bot

Loading

YuJuncen commented Apr 17, 2023

BornChanger Apr 26, 2023

BornChanger Apr 26, 2023

BornChanger left a comment

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

ti-chi-bot bot commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

ti-chi-bot bot commented May 5, 2023

YuJuncen commented May 6, 2023

	// oneshotExecutor warps a executor, making its `Next` would only be called once.
	// oneshotExecutor wraps a executor, making its `Next` would only be called once.

sql: implement SHOW BR JOBS <n:int> and CANCEL BR JOB <n:int> #43074

sql: implement SHOW BR JOBS <n:int> and CANCEL BR JOB <n:int> #43074

Conversation

YuJuncen commented Apr 14, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Apr 14, 2023 • edited by ti-chi-bot bot Loading

YuJuncen commented Apr 17, 2023

BornChanger Apr 26, 2023

Choose a reason for hiding this comment

BornChanger Apr 26, 2023

Choose a reason for hiding this comment

BornChanger left a comment

Choose a reason for hiding this comment

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

ti-chi-bot bot commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

YuJuncen commented May 5, 2023

ti-chi-bot bot commented May 5, 2023

YuJuncen commented May 6, 2023

sql: implement `SHOW BR JOBS <n:int>` and `CANCEL BR JOB <n:int>` #43074

sql: implement `SHOW BR JOBS <n:int>` and `CANCEL BR JOB <n:int>` #43074

YuJuncen commented Apr 14, 2023 •

edited

Loading

ti-chi-bot commented Apr 14, 2023 •

edited by ti-chi-bot bot

Loading