-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/cmd: implement the operator pause-gc-and-schedulers
command
#43562
Conversation
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: hillium <yujuncen@pingcap.com>
operator pause-gc
commandoperator pause-gc-and-schedulers
command
/retest-required |
Signed-off-by: hillium <yujuncen@pingcap.com>
…r-cmds Signed-off-by: hillium <yujuncen@pingcap.com>
/retest-required |
Signed-off-by: hillium <yujuncen@pingcap.com>
@@ -49,6 +49,7 @@ func main() { | |||
NewBackupCommand(), | |||
NewRestoreCommand(), | |||
NewStreamCommand(), | |||
newOpeartorCommand(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newOpeartorCommand(), | |
NewOpeartorCommand(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this shouldn't be public function. 🤔️
/retest |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fca8160
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: ref #43559
Problem Summary:
This PR implements the new (hidden) command "br operator pause-gc", which blocks the shell and then pause the global GC safepoint.
There are two flags for this command:
--safepoint
or-t
, the GC safepoint to be kept, default current resolved ts.--ttl
or-i
, how long the service safe point lives, default 5 mins.What is changed and how it works?
This PR just reused the
StartServiceGcSafePointKeeper
.Check List
Tests
(It is not easy to auto test this PR.)
Firstly, we paused the safepoint.
The metrics shows that the safepoint has been kept.
This test also applies to the schedulers.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.