Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/backup_ebs: added flag operator-paused-gc-and-scheduler. (#43687) #43926

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43687

What problem does this PR solve?

Issue Number: ref #43559

Problem Summary:
After #43562, we get the ability of pausing GC and schedulers in an external pod. But the backup command still tries to pause them, which is not really effective and will bring the ABA problem. (Say, some of BRs think the state of "no scheduler exists" is the original state of the cluster.)

What is changed and how it works?

This PR added a new hidden flag --operator-paused-gc-and-scheduler. Once it set, the client will no longer try to pause scheduler (Should / Is it possible to further check whether they are really paused?) and start backup directly after the pending split done.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Run command:
br_ebs_backup_mocking_wait_snapshot_duration=800s ~/br-operator backup full --type aws-ebs --skip-aws -u http://upd-1:2379 -s noop://
image

The schedulers are paused.

Run command:

 br_ebs_backup_mocking_wait_snapshot_duration=800s ~/br-operator backup full --type aws-ebs --skip-aws --operator-paused-gc-and-scheduler -u http://upd-1:2379 -s noop://
image

The schedulers are not paused.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label May 17, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e982138

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit a7d56db into pingcap:release-6.5 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants