Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/backup_ebs: added flag operator-paused-gc-and-scheduler. (#43687) #43926

Merged
merged 2 commits into from
May 18, 2023
Merged

br/backup_ebs: added flag operator-paused-gc-and-scheduler. (#43687) #43926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76393ea
added flag `operator-paused-gc-and-scheduler`.
YuJuncen May 10, 2023
e982138
make fmt
YuJuncen May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions br/pkg/task/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,12 @@ type BackupConfig struct {
CompressionConfig

// for ebs-based backup
FullBackupType FullBackupType `json:"full-backup-type" toml:"full-backup-type"`
VolumeFile string `json:"volume-file" toml:"volume-file"`
SkipAWS bool `json:"skip-aws" toml:"skip-aws"`
CloudAPIConcurrency uint `json:"cloud-api-concurrency" toml:"cloud-api-concurrency"`
ProgressFile string `json:"progress-file" toml:"progress-file"`
FullBackupType FullBackupType `json:"full-backup-type" toml:"full-backup-type"`
VolumeFile string `json:"volume-file" toml:"volume-file"`
SkipAWS bool `json:"skip-aws" toml:"skip-aws"`
CloudAPIConcurrency uint `json:"cloud-api-concurrency" toml:"cloud-api-concurrency"`
ProgressFile string `json:"progress-file" toml:"progress-file"`
SkipPauseGCAndScheduler bool `json:"skip-pause-gc-and-scheduler" toml:"skip-pause-gc-and-scheduler"`
}

// DefineBackupFlags defines common flags for the backup command.
Expand Down Expand Up @@ -233,6 +234,10 @@ func (cfg *BackupConfig) ParseFromFlags(flags *pflag.FlagSet) error {
if err != nil {
return errors.Trace(err)
}
cfg.SkipPauseGCAndScheduler, err = flags.GetBool(flagOperatorPausedGCAndSchedulers)
if err != nil {
return errors.Trace(err)
}
}

return nil
Expand Down
87 changes: 58 additions & 29 deletions br/pkg/task/backup_ebs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"encoding/json"
"fmt"
"io"
"os"
"sort"
"sync"
"time"
Expand All @@ -26,6 +27,7 @@ import (
"github.com/pingcap/tidb/br/pkg/conn/util"
"github.com/pingcap/tidb/br/pkg/glue"
"github.com/pingcap/tidb/br/pkg/metautil"
"github.com/pingcap/tidb/br/pkg/pdutil"
"github.com/pingcap/tidb/br/pkg/storage"
"github.com/pingcap/tidb/br/pkg/summary"
"github.com/pingcap/tidb/br/pkg/utils"
Expand Down Expand Up @@ -55,12 +57,14 @@ func DefineBackupEBSFlags(flags *pflag.FlagSet) {
flags.Bool(flagSkipAWS, false, "don't access to aws environment if set to true")
flags.Uint(flagCloudAPIConcurrency, defaultCloudAPIConcurrency, "concurrency of calling cloud api")
flags.String(flagProgressFile, "progress.txt", "the file name of progress file")
flags.Bool(flagOperatorPausedGCAndSchedulers, false, "if the GC and scheduler are paused by the `operator` command in another therad, set this so we can skip pausing GC and schedulers.")

_ = flags.MarkHidden(flagFullBackupType)
_ = flags.MarkHidden(flagBackupVolumeFile)
_ = flags.MarkHidden(flagSkipAWS)
_ = flags.MarkHidden(flagCloudAPIConcurrency)
_ = flags.MarkHidden(flagProgressFile)
_ = flags.MarkHidden(flagOperatorPausedGCAndSchedulers)
}

// RunBackupEBS starts a backup task to backup volume vai EBS snapshot.
Expand Down Expand Up @@ -131,24 +135,28 @@ func RunBackupEBS(c context.Context, g glue.Glue, cfg *BackupConfig) error {
}

// Step.1.1 stop scheduler as much as possible.
log.Info("starting to remove some PD schedulers")
restoreFunc, e := mgr.RemoveAllPDSchedulers(ctx)
if e != nil {
return errors.Trace(err)
}
var scheduleRestored bool
defer func() {
if ctx.Err() != nil {
log.Warn("context canceled, doing clean work with background context")
ctx = context.Background()
}
if scheduleRestored {
return
}
if restoreE := restoreFunc(ctx); restoreE != nil {
log.Warn("failed to restore removed schedulers, you may need to restore them manually", zap.Error(restoreE))
log.Info("starting to remove some PD schedulers and pausing GC", zap.Bool("already-paused-by-operator", cfg.SkipPauseGCAndScheduler))
var restoreFunc pdutil.UndoFunc

if !cfg.SkipPauseGCAndScheduler {
var e error
restoreFunc, e = mgr.RemoveAllPDSchedulers(ctx)
if e != nil {
return errors.Trace(err)
}
}()
defer func() {
if ctx.Err() != nil {
log.Warn("context canceled, doing clean work with background context")
ctx = context.Background()
}
if restoreFunc == nil {
return
}
if restoreE := restoreFunc(ctx); restoreE != nil {
log.Warn("failed to restore removed schedulers, you may need to restore them manually", zap.Error(restoreE))
}
}()
}

if err := waitAllScheduleStoppedAndNoRegionHole(ctx, cfg.Config, mgr); err != nil {
return errors.Trace(err)
Expand All @@ -159,15 +167,17 @@ func RunBackupEBS(c context.Context, g glue.Glue, cfg *BackupConfig) error {
if err != nil {
return errors.Trace(err)
}
sp := utils.BRServiceSafePoint{
BackupTS: resolvedTs,
TTL: utils.DefaultBRGCSafePointTTL,
ID: utils.MakeSafePointID(),
}
log.Info("safe point will be stuck during ebs backup", zap.Object("safePoint", sp))
err = utils.StartServiceSafePointKeeper(ctx, mgr.GetPDClient(), sp)
if err != nil {
return errors.Trace(err)
if !cfg.SkipPauseGCAndScheduler {
sp := utils.BRServiceSafePoint{
BackupTS: resolvedTs,
TTL: utils.DefaultBRGCSafePointTTL,
ID: utils.MakeSafePointID(),
}
log.Info("safe point will be stuck during ebs backup", zap.Object("safePoint", sp))
err = utils.StartServiceSafePointKeeper(ctx, mgr.GetPDClient(), sp)
if err != nil {
return errors.Trace(err)
}
}

// Step.1.3 backup the key info to recover cluster. e.g. PD alloc_id/cluster_id
Expand Down Expand Up @@ -210,7 +220,8 @@ func RunBackupEBS(c context.Context, g glue.Glue, cfg *BackupConfig) error {
if restoreE := restoreFunc(ctx); restoreE != nil {
log.Warn("failed to restore removed schedulers, you may need to restore them manually", zap.Error(restoreE))
} else {
scheduleRestored = true
// Clear the restore func, so we won't execute it many times.
restoreFunc = nil
}

log.Info("wait async snapshots finish")
Expand All @@ -223,8 +234,13 @@ func RunBackupEBS(c context.Context, g glue.Glue, cfg *BackupConfig) error {
for i := 0; i < int(storeCount); i++ {
progress.IncBy(100)
totalSize = 1024
log.Info("mock snapshot finished.", zap.Int("index", i))
time.Sleep(800 * time.Millisecond)
timeToSleep := getMockSleepTime()
log.Info("mock snapshot finished.", zap.Int("index", i), zap.Duration("time-to-sleep", timeToSleep))
select {
case <-ctx.Done():
return errors.Trace(ctx.Err())
case <-time.After(timeToSleep):
}
}
}
progress.Close()
Expand All @@ -245,6 +261,19 @@ func RunBackupEBS(c context.Context, g glue.Glue, cfg *BackupConfig) error {
return nil
}

func getMockSleepTime() time.Duration {
dft := 800 * time.Millisecond
v, ok := os.LookupEnv("br_ebs_backup_mocking_wait_snapshot_duration")
if !ok {
return dft
}
d, err := time.ParseDuration(v)
if err != nil {
return dft
}
return d
}

func waitAllScheduleStoppedAndNoRegionHole(ctx context.Context, cfg Config, mgr *conn.Mgr) error {
allStores, err := conn.GetAllTiKVStoresWithRetry(ctx, mgr.GetPDClient(), util.SkipTiFlash)
if err != nil {
Expand Down
7 changes: 4 additions & 3 deletions br/pkg/task/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,10 @@ const (
flagSkipCheckPath = "skip-check-path"
flagDryRun = "dry-run"
// TODO used for local test, should be removed later
flagSkipAWS = "skip-aws"
flagCloudAPIConcurrency = "cloud-api-concurrency"
flagWithSysTable = "with-sys-table"
flagSkipAWS = "skip-aws"
flagCloudAPIConcurrency = "cloud-api-concurrency"
flagWithSysTable = "with-sys-table"
flagOperatorPausedGCAndSchedulers = "operator-paused-gc-and-scheduler"

defaultSwitchInterval = 5 * time.Minute
defaultGRPCKeepaliveTime = 10 * time.Second
Expand Down