Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br/cmd: implement the operator pause-gc-and-schedulers command (#43562) #43925

Merged
merged 2 commits into from
May 23, 2023
Merged

br/cmd: implement the operator pause-gc-and-schedulers command (#43562) #43925

merged 2 commits into from
May 23, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43562

What problem does this PR solve?

Issue Number: ref #43559
Problem Summary:
This PR implements the new (hidden) command "br operator pause-gc", which blocks the shell and then pause the global GC safepoint.
There are two flags for this command:
--safepoint or -t, the GC safepoint to be kept, default current resolved ts.
--ttl or -i, how long the service safe point lives, default 5 mins.

What is changed and how it works?

This PR just reused the StartServiceGcSafePointKeeper.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    (It is not easy to auto test this PR.)
    Firstly, we paused the safepoint.

image

The metrics shows that the safepoint has been kept.

image

This test also applies to the schedulers.

image

  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@YuJuncen @ti-chi-bot
This is an automated cherry-pick of pingcap#43562
0711c54 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
4 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 17, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels May 17, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

@YuJuncen: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0711c54

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
hawkingrei
hawkingrei reviewed May 23, 2023
View reviewed changes
br/pkg/pdutil/pd.go Outdated
@@ -254,7 +254,12 @@ func NewPdController(
}
}
if failure != nil {
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix it.

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@YuJuncen
Copy link
Contributor

/test unit-test

@ti-chi-bot ti-chi-bot bot merged commit d20a564 into pingcap:release-6.5 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@Leavrth Leavrth Leavrth approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees

@YuJuncen YuJuncen

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @YuJuncen @hawkingrei @Leavrth @VelocityLight